Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1864313002: Fix UaF of BlinkTestRunner caused by incorrect base::Unretained. (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix UaF of BlinkTestRunner caused by incorrect base::Unretained. BUG=601089 Committed: https://crrev.com/647f8addf5b416dfc0b1742e22c85d02ec2b8791 Cr-Commit-Position: refs/heads/master@{#385754}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Łukasz Anforowicz
jochen@, could you please take a look? https://codereview.chromium.org/1864313002/diff/1/content/shell/renderer/layout_test/blink_test_runner.cc File content/shell/renderer/layout_test/blink_test_runner.cc (right): https://codereview.chromium.org/1864313002/diff/1/content/shell/renderer/layout_test/blink_test_runner.cc#newcode906 content/shell/renderer/layout_test/blink_test_runner.cc:906: Send(new ShellViewHostMsg_TestFinished(routing_id())); ...
4 years, 8 months ago (2016-04-06 22:45:29 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-07 03:39:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864313002/20001
4 years, 8 months ago (2016-04-07 14:08:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 14:46:22 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 14:48:16 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/647f8addf5b416dfc0b1742e22c85d02ec2b8791
Cr-Commit-Position: refs/heads/master@{#385754}

Powered by Google App Engine
This is Rietveld 408576698