Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1864303002: Switch uniforms to be descriptor set 0 in Vulkan (Closed)

Created:
4 years, 8 months ago by egdaniel
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Switch uniforms to be descriptor set 0 in Vulkan This (plus some cleanup) gives us some minor perf gains and as a side effect the perf debug layer no longer complains when we bind certain descriptor sets. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864303002 Committed: https://skia.googlesource.com/skia/+/b4aa36211ca66ef127ac2954108742af1ead5082

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M src/gpu/vk/GrVkGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 6 chunks +16 lines, -9 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateBuilder.cpp View 2 chunks +3 lines, -3 lines 1 comment Download
M src/gpu/vk/GrVkUniformHandler.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
egdaniel
https://codereview.chromium.org/1864303002/diff/1/src/gpu/vk/GrVkPipelineStateBuilder.cpp File src/gpu/vk/GrVkPipelineStateBuilder.cpp (right): https://codereview.chromium.org/1864303002/diff/1/src/gpu/vk/GrVkPipelineStateBuilder.cpp#newcode206 src/gpu/vk/GrVkPipelineStateBuilder.cpp:206: dsUniBindings[0].descriptorCount = 1; This is needed so that the ...
4 years, 8 months ago (2016-04-06 20:22:48 UTC) #3
jvanverth1
lgtm
4 years, 8 months ago (2016-04-06 20:32:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864303002/1
4 years, 8 months ago (2016-04-06 20:34:14 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 20:47:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b4aa36211ca66ef127ac2954108742af1ead5082

Powered by Google App Engine
This is Rietveld 408576698