Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4140)

Unified Diff: chrome/renderer/pepper/chrome_renderer_pepper_host_factory.cc

Issue 1864293002: Convert //ppapi to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more nullptr Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/pepper/chrome_renderer_pepper_host_factory.cc
diff --git a/chrome/renderer/pepper/chrome_renderer_pepper_host_factory.cc b/chrome/renderer/pepper/chrome_renderer_pepper_host_factory.cc
index a78d9ea330400373855380d5f7d958b8c10c165e..c1e2d1a09751ff3f01cc44171a4156560367e57e 100644
--- a/chrome/renderer/pepper/chrome_renderer_pepper_host_factory.cc
+++ b/chrome/renderer/pepper/chrome_renderer_pepper_host_factory.cc
@@ -5,6 +5,7 @@
#include "chrome/renderer/pepper/chrome_renderer_pepper_host_factory.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
#include "chrome/renderer/pepper/pepper_flash_drm_renderer_host.h"
#include "chrome/renderer/pepper/pepper_flash_font_file_host.h"
#include "chrome/renderer/pepper/pepper_flash_fullscreen_host.h"
@@ -27,7 +28,8 @@ ChromeRendererPepperHostFactory::ChromeRendererPepperHostFactory(
ChromeRendererPepperHostFactory::~ChromeRendererPepperHostFactory() {}
-scoped_ptr<ResourceHost> ChromeRendererPepperHostFactory::CreateResourceHost(
+std::unique_ptr<ResourceHost>
+ChromeRendererPepperHostFactory::CreateResourceHost(
ppapi::host::PpapiHost* host,
PP_Resource resource,
PP_Instance instance,
@@ -36,24 +38,24 @@ scoped_ptr<ResourceHost> ChromeRendererPepperHostFactory::CreateResourceHost(
// Make sure the plugin is giving us a valid instance for this resource.
if (!host_->IsValidInstance(instance))
- return scoped_ptr<ResourceHost>();
+ return nullptr;
if (host_->GetPpapiHost()->permissions().HasPermission(
ppapi::PERMISSION_FLASH)) {
switch (message.type()) {
case PpapiHostMsg_Flash_Create::ID: {
- return scoped_ptr<ResourceHost>(
+ return base::WrapUnique(
new PepperFlashRendererHost(host_, instance, resource));
}
case PpapiHostMsg_FlashFullscreen_Create::ID: {
- return scoped_ptr<ResourceHost>(
+ return base::WrapUnique(
new PepperFlashFullscreenHost(host_, instance, resource));
}
case PpapiHostMsg_FlashMenu_Create::ID: {
ppapi::proxy::SerializedFlashMenu serialized_menu;
if (ppapi::UnpackMessage<PpapiHostMsg_FlashMenu_Create>(
message, &serialized_menu)) {
- return scoped_ptr<ResourceHost>(new PepperFlashMenuHost(
+ return base::WrapUnique(new PepperFlashMenuHost(
host_, instance, resource, serialized_menu));
}
break;
@@ -74,13 +76,13 @@ scoped_ptr<ResourceHost> ChromeRendererPepperHostFactory::CreateResourceHost(
PP_PrivateFontCharset charset;
if (ppapi::UnpackMessage<PpapiHostMsg_FlashFontFile_Create>(
message, &description, &charset)) {
- return scoped_ptr<ResourceHost>(new PepperFlashFontFileHost(
+ return base::WrapUnique(new PepperFlashFontFileHost(
host_, instance, resource, description, charset));
}
break;
}
case PpapiHostMsg_FlashDRM_Create::ID:
- return scoped_ptr<ResourceHost>(
+ return base::WrapUnique(
new PepperFlashDRMRendererHost(host_, instance, resource));
}
}
@@ -89,7 +91,7 @@ scoped_ptr<ResourceHost> ChromeRendererPepperHostFactory::CreateResourceHost(
ppapi::PERMISSION_PRIVATE)) {
switch (message.type()) {
case PpapiHostMsg_PDF_Create::ID: {
- return scoped_ptr<ResourceHost>(
+ return base::WrapUnique(
new pdf::PepperPDFHost(host_, instance, resource));
}
}
@@ -101,10 +103,9 @@ scoped_ptr<ResourceHost> ChromeRendererPepperHostFactory::CreateResourceHost(
// access to the other private interfaces.
switch (message.type()) {
case PpapiHostMsg_UMA_Create::ID: {
- return scoped_ptr<ResourceHost>(
- new PepperUMAHost(host_, instance, resource));
+ return base::WrapUnique(new PepperUMAHost(host_, instance, resource));
}
}
- return scoped_ptr<ResourceHost>();
+ return nullptr;
}
« no previous file with comments | « chrome/renderer/pepper/chrome_renderer_pepper_host_factory.h ('k') | chrome/renderer/pepper/pepper_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698