Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: ppapi/proxy/file_io_resource.cc

Issue 1864293002: Convert //ppapi to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/file_io_resource.cc
diff --git a/ppapi/proxy/file_io_resource.cc b/ppapi/proxy/file_io_resource.cc
index 1279c46b363a0de5132999c2e42d5d443e572917..519389e9a4a1406bfc5519c21c5616636aab4a01 100644
--- a/ppapi/proxy/file_io_resource.cc
+++ b/ppapi/proxy/file_io_resource.cc
@@ -82,7 +82,7 @@ int32_t FileIOResource::ReadOp::DoWork() {
FileIOResource::WriteOp::WriteOp(scoped_refptr<FileHolder> file_holder,
int64_t offset,
- scoped_ptr<char[]> buffer,
+ std::unique_ptr<char[]> buffer,
int32_t bytes_to_write,
bool append)
: file_holder_(file_holder),
@@ -301,7 +301,7 @@ int32_t FileIOResource::Write(int64_t offset,
if (increase > 0) {
// Request a quota reservation. This makes the Write asynchronous, so we
// must copy the plugin's buffer.
- scoped_ptr<char[]> copy(new char[bytes_to_write]);
+ std::unique_ptr<char[]> copy(new char[bytes_to_write]);
memcpy(copy.get(), buffer, bytes_to_write);
int64_t result =
file_system_resource_->AsPPB_FileSystem_API()->RequestQuota(
@@ -515,7 +515,7 @@ int32_t FileIOResource::WriteValidated(
// For the non-blocking case, post a task to the file thread. We must copy the
// plugin's buffer at this point.
- scoped_ptr<char[]> copy(new char[bytes_to_write]);
+ std::unique_ptr<char[]> copy(new char[bytes_to_write]);
memcpy(copy.get(), buffer, bytes_to_write);
scoped_refptr<WriteOp> write_op(new WriteOp(
file_holder_, offset, std::move(copy), bytes_to_write, append));
@@ -582,7 +582,7 @@ int32_t FileIOResource::OnReadComplete(scoped_refptr<ReadOp> read_op,
void FileIOResource::OnRequestWriteQuotaComplete(
int64_t offset,
- scoped_ptr<char[]> buffer,
+ std::unique_ptr<char[]> buffer,
int32_t bytes_to_write,
scoped_refptr<TrackedCallback> callback,
int64_t granted) {

Powered by Google App Engine
This is Rietveld 408576698