Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: ppapi/shared_impl/media_stream_buffer_manager_unittest.cc

Issue 1864293002: Convert //ppapi to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more nullptr Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/shared_impl/media_stream_buffer_manager.cc ('k') | ppapi/shared_impl/ppb_audio_shared.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ppapi/shared_impl/media_stream_buffer_manager.h" 5 #include "ppapi/shared_impl/media_stream_buffer_manager.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
11 #include "base/memory/scoped_ptr.h"
12 #include "base/memory/shared_memory.h" 11 #include "base/memory/shared_memory.h"
13 #include "ppapi/c/pp_errors.h" 12 #include "ppapi/c/pp_errors.h"
14 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
15 14
16 using base::SharedMemory; 15 using base::SharedMemory;
17 using base::SharedMemoryCreateOptions; 16 using base::SharedMemoryCreateOptions;
18 17
19 namespace { 18 namespace {
20 19
21 scoped_ptr<SharedMemory> CreateSharedMemory(int32_t buffer_size, 20 std::unique_ptr<SharedMemory> CreateSharedMemory(int32_t buffer_size,
22 int32_t number_of_buffers) { 21 int32_t number_of_buffers) {
23 scoped_ptr<SharedMemory> shared_memory(new SharedMemory()); 22 std::unique_ptr<SharedMemory> shared_memory(new SharedMemory());
24 SharedMemoryCreateOptions options; 23 SharedMemoryCreateOptions options;
25 options.size = buffer_size * number_of_buffers; 24 options.size = buffer_size * number_of_buffers;
26 options.executable = false; 25 options.executable = false;
27 EXPECT_TRUE(shared_memory->Create(options)); 26 EXPECT_TRUE(shared_memory->Create(options));
28 return shared_memory; 27 return shared_memory;
29 } 28 }
30 29
31 } // namespace 30 } // namespace
32 31
33 namespace ppapi { 32 namespace ppapi {
34 33
35 class MockDelegate : public MediaStreamBufferManager::Delegate { 34 class MockDelegate : public MediaStreamBufferManager::Delegate {
36 public: 35 public:
37 MockDelegate() : new_buffer_enqueue_counter_(0) {} 36 MockDelegate() : new_buffer_enqueue_counter_(0) {}
38 void OnNewBufferEnqueued() override { 37 void OnNewBufferEnqueued() override {
39 new_buffer_enqueue_counter_++; 38 new_buffer_enqueue_counter_++;
40 } 39 }
41 40
42 int32_t new_buffer_enqueue_counter_; 41 int32_t new_buffer_enqueue_counter_;
43 }; 42 };
44 43
45 TEST(MediaStreamBufferManager, General) { 44 TEST(MediaStreamBufferManager, General) {
46 { 45 {
47 const int32_t kNumberOfBuffers = 5; 46 const int32_t kNumberOfBuffers = 5;
48 const int32_t kBufferSize = 128; 47 const int32_t kBufferSize = 128;
49 MockDelegate delegate; 48 MockDelegate delegate;
50 MediaStreamBufferManager manager(&delegate); 49 MediaStreamBufferManager manager(&delegate);
51 scoped_ptr<SharedMemory> shared_memory = 50 std::unique_ptr<SharedMemory> shared_memory =
52 CreateSharedMemory(kBufferSize, kNumberOfBuffers); 51 CreateSharedMemory(kBufferSize, kNumberOfBuffers);
53 // SetBuffers with enqueue_all_buffers = true; 52 // SetBuffers with enqueue_all_buffers = true;
54 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers, kBufferSize, 53 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers, kBufferSize,
55 std::move(shared_memory), true)); 54 std::move(shared_memory), true));
56 55
57 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0)); 56 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0));
58 EXPECT_NE(static_cast<int8_t*>(NULL), memory); 57 EXPECT_NE(static_cast<int8_t*>(NULL), memory);
59 58
60 EXPECT_EQ(kNumberOfBuffers, manager.number_of_buffers()); 59 EXPECT_EQ(kNumberOfBuffers, manager.number_of_buffers());
61 EXPECT_EQ(kBufferSize, manager.buffer_size()); 60 EXPECT_EQ(kBufferSize, manager.buffer_size());
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 EXPECT_DEATH(manager.EnqueueBuffer(kNumberOfBuffers), 97 EXPECT_DEATH(manager.EnqueueBuffer(kNumberOfBuffers),
99 ".*Check failed: index < number_of_buffers_.*"); 98 ".*Check failed: index < number_of_buffers_.*");
100 #endif 99 #endif
101 } 100 }
102 101
103 { 102 {
104 const int32_t kNumberOfBuffers = 5; 103 const int32_t kNumberOfBuffers = 5;
105 const int32_t kBufferSize = 128; 104 const int32_t kBufferSize = 128;
106 MockDelegate delegate; 105 MockDelegate delegate;
107 MediaStreamBufferManager manager(&delegate); 106 MediaStreamBufferManager manager(&delegate);
108 scoped_ptr<SharedMemory> shared_memory = 107 std::unique_ptr<SharedMemory> shared_memory =
109 CreateSharedMemory(kBufferSize, kNumberOfBuffers); 108 CreateSharedMemory(kBufferSize, kNumberOfBuffers);
110 // SetBuffers with enqueue_all_buffers = false; 109 // SetBuffers with enqueue_all_buffers = false;
111 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers, kBufferSize, 110 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers, kBufferSize,
112 std::move(shared_memory), false)); 111 std::move(shared_memory), false));
113 112
114 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0)); 113 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0));
115 EXPECT_NE(static_cast<int8_t*>(NULL), memory); 114 EXPECT_NE(static_cast<int8_t*>(NULL), memory);
116 115
117 EXPECT_EQ(kNumberOfBuffers, manager.number_of_buffers()); 116 EXPECT_EQ(kNumberOfBuffers, manager.number_of_buffers());
118 EXPECT_EQ(kBufferSize, manager.buffer_size()); 117 EXPECT_EQ(kBufferSize, manager.buffer_size());
119 118
120 // Test DequeueBuffer() and GetBufferPointer() 119 // Test DequeueBuffer() and GetBufferPointer()
121 for (int32_t i = 0; i < kNumberOfBuffers; ++i) { 120 for (int32_t i = 0; i < kNumberOfBuffers; ++i) {
122 EXPECT_EQ(PP_ERROR_FAILED, manager.DequeueBuffer()); 121 EXPECT_EQ(PP_ERROR_FAILED, manager.DequeueBuffer());
123 EXPECT_EQ(reinterpret_cast<MediaStreamBuffer*>(memory + i * kBufferSize), 122 EXPECT_EQ(reinterpret_cast<MediaStreamBuffer*>(memory + i * kBufferSize),
124 manager.GetBufferPointer(i)); 123 manager.GetBufferPointer(i));
125 } 124 }
126 } 125 }
127 } 126 }
128 127
129 TEST(MediaStreamBufferManager, ResetBuffers) { 128 TEST(MediaStreamBufferManager, ResetBuffers) {
130 const int32_t kNumberOfBuffers1 = 5; 129 const int32_t kNumberOfBuffers1 = 5;
131 const int32_t kBufferSize1 = 128; 130 const int32_t kBufferSize1 = 128;
132 const int32_t kNumberOfBuffers2 = 8; 131 const int32_t kNumberOfBuffers2 = 8;
133 const int32_t kBufferSize2 = 256; 132 const int32_t kBufferSize2 = 256;
134 MockDelegate delegate; 133 MockDelegate delegate;
135 MediaStreamBufferManager manager(&delegate); 134 MediaStreamBufferManager manager(&delegate);
136 { 135 {
137 scoped_ptr<SharedMemory> shared_memory(new SharedMemory()); 136 std::unique_ptr<SharedMemory> shared_memory(new SharedMemory());
138 SharedMemoryCreateOptions options; 137 SharedMemoryCreateOptions options;
139 options.size = kBufferSize1 * kNumberOfBuffers1; 138 options.size = kBufferSize1 * kNumberOfBuffers1;
140 options.executable = false; 139 options.executable = false;
141 140
142 EXPECT_TRUE(shared_memory->Create(options)); 141 EXPECT_TRUE(shared_memory->Create(options));
143 142
144 // SetBuffers with enqueue_all_buffers = true; 143 // SetBuffers with enqueue_all_buffers = true;
145 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers1, kBufferSize1, 144 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers1, kBufferSize1,
146 std::move(shared_memory), true)); 145 std::move(shared_memory), true));
147 146
148 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0)); 147 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0));
149 EXPECT_NE(static_cast<int8_t*>(NULL), memory); 148 EXPECT_NE(static_cast<int8_t*>(NULL), memory);
150 149
151 EXPECT_EQ(kNumberOfBuffers1, manager.number_of_buffers()); 150 EXPECT_EQ(kNumberOfBuffers1, manager.number_of_buffers());
152 EXPECT_EQ(kBufferSize1, manager.buffer_size()); 151 EXPECT_EQ(kBufferSize1, manager.buffer_size());
153 152
154 // Test DequeueBuffer() and GetBufferPointer() 153 // Test DequeueBuffer() and GetBufferPointer()
155 for (int32_t i = 0; i < kNumberOfBuffers1; ++i) { 154 for (int32_t i = 0; i < kNumberOfBuffers1; ++i) {
156 EXPECT_EQ(i, manager.DequeueBuffer()); 155 EXPECT_EQ(i, manager.DequeueBuffer());
157 EXPECT_EQ(reinterpret_cast<MediaStreamBuffer*>(memory + i * kBufferSize1), 156 EXPECT_EQ(reinterpret_cast<MediaStreamBuffer*>(memory + i * kBufferSize1),
158 manager.GetBufferPointer(i)); 157 manager.GetBufferPointer(i));
159 } 158 }
160 } 159 }
161 160
162 { 161 {
163 scoped_ptr<SharedMemory> shared_memory = 162 std::unique_ptr<SharedMemory> shared_memory =
164 CreateSharedMemory(kBufferSize2, kNumberOfBuffers2); 163 CreateSharedMemory(kBufferSize2, kNumberOfBuffers2);
165 // SetBuffers with enqueue_all_buffers = true; 164 // SetBuffers with enqueue_all_buffers = true;
166 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers2, kBufferSize2, 165 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers2, kBufferSize2,
167 std::move(shared_memory), true)); 166 std::move(shared_memory), true));
168 167
169 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0)); 168 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0));
170 EXPECT_NE(static_cast<int8_t*>(NULL), memory); 169 EXPECT_NE(static_cast<int8_t*>(NULL), memory);
171 170
172 EXPECT_EQ(kNumberOfBuffers2, manager.number_of_buffers()); 171 EXPECT_EQ(kNumberOfBuffers2, manager.number_of_buffers());
173 EXPECT_EQ(kBufferSize2, manager.buffer_size()); 172 EXPECT_EQ(kBufferSize2, manager.buffer_size());
174 173
175 // Test DequeueBuffer() and GetBufferPointer() 174 // Test DequeueBuffer() and GetBufferPointer()
176 for (int32_t i = 0; i < kNumberOfBuffers2; ++i) { 175 for (int32_t i = 0; i < kNumberOfBuffers2; ++i) {
177 EXPECT_EQ(i, manager.DequeueBuffer()); 176 EXPECT_EQ(i, manager.DequeueBuffer());
178 EXPECT_EQ(reinterpret_cast<MediaStreamBuffer*>(memory + i * kBufferSize2), 177 EXPECT_EQ(reinterpret_cast<MediaStreamBuffer*>(memory + i * kBufferSize2),
179 manager.GetBufferPointer(i)); 178 manager.GetBufferPointer(i));
180 } 179 }
181 } 180 }
182 } 181 }
183 182
184 } // namespace ppapi 183 } // namespace ppapi
OLDNEW
« no previous file with comments | « ppapi/shared_impl/media_stream_buffer_manager.cc ('k') | ppapi/shared_impl/ppb_audio_shared.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698