Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: ppapi/shared_impl/media_stream_buffer_manager_unittest.cc

Issue 1864293002: Convert //ppapi to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ppapi/shared_impl/media_stream_buffer_manager.h" 5 #include "ppapi/shared_impl/media_stream_buffer_manager.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory>
bbudge 2016/04/06 21:01:20 Is included by media_stream_buffer_manager.h
dcheng 2016/04/06 21:18:33 Done.
9 #include <utility> 10 #include <utility>
10 11
11 #include "base/memory/scoped_ptr.h"
12 #include "base/memory/shared_memory.h" 12 #include "base/memory/shared_memory.h"
13 #include "ppapi/c/pp_errors.h" 13 #include "ppapi/c/pp_errors.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 using base::SharedMemory; 16 using base::SharedMemory;
17 using base::SharedMemoryCreateOptions; 17 using base::SharedMemoryCreateOptions;
18 18
19 namespace { 19 namespace {
20 20
21 scoped_ptr<SharedMemory> CreateSharedMemory(int32_t buffer_size, 21 std::unique_ptr<SharedMemory> CreateSharedMemory(int32_t buffer_size,
22 int32_t number_of_buffers) { 22 int32_t number_of_buffers) {
23 scoped_ptr<SharedMemory> shared_memory(new SharedMemory()); 23 std::unique_ptr<SharedMemory> shared_memory(new SharedMemory());
24 SharedMemoryCreateOptions options; 24 SharedMemoryCreateOptions options;
25 options.size = buffer_size * number_of_buffers; 25 options.size = buffer_size * number_of_buffers;
26 options.executable = false; 26 options.executable = false;
27 EXPECT_TRUE(shared_memory->Create(options)); 27 EXPECT_TRUE(shared_memory->Create(options));
28 return shared_memory; 28 return shared_memory;
29 } 29 }
30 30
31 } // namespace 31 } // namespace
32 32
33 namespace ppapi { 33 namespace ppapi {
34 34
35 class MockDelegate : public MediaStreamBufferManager::Delegate { 35 class MockDelegate : public MediaStreamBufferManager::Delegate {
36 public: 36 public:
37 MockDelegate() : new_buffer_enqueue_counter_(0) {} 37 MockDelegate() : new_buffer_enqueue_counter_(0) {}
38 void OnNewBufferEnqueued() override { 38 void OnNewBufferEnqueued() override {
39 new_buffer_enqueue_counter_++; 39 new_buffer_enqueue_counter_++;
40 } 40 }
41 41
42 int32_t new_buffer_enqueue_counter_; 42 int32_t new_buffer_enqueue_counter_;
43 }; 43 };
44 44
45 TEST(MediaStreamBufferManager, General) { 45 TEST(MediaStreamBufferManager, General) {
46 { 46 {
47 const int32_t kNumberOfBuffers = 5; 47 const int32_t kNumberOfBuffers = 5;
48 const int32_t kBufferSize = 128; 48 const int32_t kBufferSize = 128;
49 MockDelegate delegate; 49 MockDelegate delegate;
50 MediaStreamBufferManager manager(&delegate); 50 MediaStreamBufferManager manager(&delegate);
51 scoped_ptr<SharedMemory> shared_memory = 51 std::unique_ptr<SharedMemory> shared_memory =
52 CreateSharedMemory(kBufferSize, kNumberOfBuffers); 52 CreateSharedMemory(kBufferSize, kNumberOfBuffers);
53 // SetBuffers with enqueue_all_buffers = true; 53 // SetBuffers with enqueue_all_buffers = true;
54 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers, kBufferSize, 54 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers, kBufferSize,
55 std::move(shared_memory), true)); 55 std::move(shared_memory), true));
56 56
57 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0)); 57 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0));
58 EXPECT_NE(static_cast<int8_t*>(NULL), memory); 58 EXPECT_NE(static_cast<int8_t*>(NULL), memory);
59 59
60 EXPECT_EQ(kNumberOfBuffers, manager.number_of_buffers()); 60 EXPECT_EQ(kNumberOfBuffers, manager.number_of_buffers());
61 EXPECT_EQ(kBufferSize, manager.buffer_size()); 61 EXPECT_EQ(kBufferSize, manager.buffer_size());
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 EXPECT_DEATH(manager.EnqueueBuffer(kNumberOfBuffers), 98 EXPECT_DEATH(manager.EnqueueBuffer(kNumberOfBuffers),
99 ".*Check failed: index < number_of_buffers_.*"); 99 ".*Check failed: index < number_of_buffers_.*");
100 #endif 100 #endif
101 } 101 }
102 102
103 { 103 {
104 const int32_t kNumberOfBuffers = 5; 104 const int32_t kNumberOfBuffers = 5;
105 const int32_t kBufferSize = 128; 105 const int32_t kBufferSize = 128;
106 MockDelegate delegate; 106 MockDelegate delegate;
107 MediaStreamBufferManager manager(&delegate); 107 MediaStreamBufferManager manager(&delegate);
108 scoped_ptr<SharedMemory> shared_memory = 108 std::unique_ptr<SharedMemory> shared_memory =
109 CreateSharedMemory(kBufferSize, kNumberOfBuffers); 109 CreateSharedMemory(kBufferSize, kNumberOfBuffers);
110 // SetBuffers with enqueue_all_buffers = false; 110 // SetBuffers with enqueue_all_buffers = false;
111 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers, kBufferSize, 111 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers, kBufferSize,
112 std::move(shared_memory), false)); 112 std::move(shared_memory), false));
113 113
114 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0)); 114 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0));
115 EXPECT_NE(static_cast<int8_t*>(NULL), memory); 115 EXPECT_NE(static_cast<int8_t*>(NULL), memory);
116 116
117 EXPECT_EQ(kNumberOfBuffers, manager.number_of_buffers()); 117 EXPECT_EQ(kNumberOfBuffers, manager.number_of_buffers());
118 EXPECT_EQ(kBufferSize, manager.buffer_size()); 118 EXPECT_EQ(kBufferSize, manager.buffer_size());
119 119
120 // Test DequeueBuffer() and GetBufferPointer() 120 // Test DequeueBuffer() and GetBufferPointer()
121 for (int32_t i = 0; i < kNumberOfBuffers; ++i) { 121 for (int32_t i = 0; i < kNumberOfBuffers; ++i) {
122 EXPECT_EQ(PP_ERROR_FAILED, manager.DequeueBuffer()); 122 EXPECT_EQ(PP_ERROR_FAILED, manager.DequeueBuffer());
123 EXPECT_EQ(reinterpret_cast<MediaStreamBuffer*>(memory + i * kBufferSize), 123 EXPECT_EQ(reinterpret_cast<MediaStreamBuffer*>(memory + i * kBufferSize),
124 manager.GetBufferPointer(i)); 124 manager.GetBufferPointer(i));
125 } 125 }
126 } 126 }
127 } 127 }
128 128
129 TEST(MediaStreamBufferManager, ResetBuffers) { 129 TEST(MediaStreamBufferManager, ResetBuffers) {
130 const int32_t kNumberOfBuffers1 = 5; 130 const int32_t kNumberOfBuffers1 = 5;
131 const int32_t kBufferSize1 = 128; 131 const int32_t kBufferSize1 = 128;
132 const int32_t kNumberOfBuffers2 = 8; 132 const int32_t kNumberOfBuffers2 = 8;
133 const int32_t kBufferSize2 = 256; 133 const int32_t kBufferSize2 = 256;
134 MockDelegate delegate; 134 MockDelegate delegate;
135 MediaStreamBufferManager manager(&delegate); 135 MediaStreamBufferManager manager(&delegate);
136 { 136 {
137 scoped_ptr<SharedMemory> shared_memory(new SharedMemory()); 137 std::unique_ptr<SharedMemory> shared_memory(new SharedMemory());
138 SharedMemoryCreateOptions options; 138 SharedMemoryCreateOptions options;
139 options.size = kBufferSize1 * kNumberOfBuffers1; 139 options.size = kBufferSize1 * kNumberOfBuffers1;
140 options.executable = false; 140 options.executable = false;
141 141
142 EXPECT_TRUE(shared_memory->Create(options)); 142 EXPECT_TRUE(shared_memory->Create(options));
143 143
144 // SetBuffers with enqueue_all_buffers = true; 144 // SetBuffers with enqueue_all_buffers = true;
145 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers1, kBufferSize1, 145 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers1, kBufferSize1,
146 std::move(shared_memory), true)); 146 std::move(shared_memory), true));
147 147
148 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0)); 148 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0));
149 EXPECT_NE(static_cast<int8_t*>(NULL), memory); 149 EXPECT_NE(static_cast<int8_t*>(NULL), memory);
150 150
151 EXPECT_EQ(kNumberOfBuffers1, manager.number_of_buffers()); 151 EXPECT_EQ(kNumberOfBuffers1, manager.number_of_buffers());
152 EXPECT_EQ(kBufferSize1, manager.buffer_size()); 152 EXPECT_EQ(kBufferSize1, manager.buffer_size());
153 153
154 // Test DequeueBuffer() and GetBufferPointer() 154 // Test DequeueBuffer() and GetBufferPointer()
155 for (int32_t i = 0; i < kNumberOfBuffers1; ++i) { 155 for (int32_t i = 0; i < kNumberOfBuffers1; ++i) {
156 EXPECT_EQ(i, manager.DequeueBuffer()); 156 EXPECT_EQ(i, manager.DequeueBuffer());
157 EXPECT_EQ(reinterpret_cast<MediaStreamBuffer*>(memory + i * kBufferSize1), 157 EXPECT_EQ(reinterpret_cast<MediaStreamBuffer*>(memory + i * kBufferSize1),
158 manager.GetBufferPointer(i)); 158 manager.GetBufferPointer(i));
159 } 159 }
160 } 160 }
161 161
162 { 162 {
163 scoped_ptr<SharedMemory> shared_memory = 163 std::unique_ptr<SharedMemory> shared_memory =
164 CreateSharedMemory(kBufferSize2, kNumberOfBuffers2); 164 CreateSharedMemory(kBufferSize2, kNumberOfBuffers2);
165 // SetBuffers with enqueue_all_buffers = true; 165 // SetBuffers with enqueue_all_buffers = true;
166 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers2, kBufferSize2, 166 EXPECT_TRUE(manager.SetBuffers(kNumberOfBuffers2, kBufferSize2,
167 std::move(shared_memory), true)); 167 std::move(shared_memory), true));
168 168
169 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0)); 169 int8_t* memory = reinterpret_cast<int8_t*>(manager.GetBufferPointer(0));
170 EXPECT_NE(static_cast<int8_t*>(NULL), memory); 170 EXPECT_NE(static_cast<int8_t*>(NULL), memory);
171 171
172 EXPECT_EQ(kNumberOfBuffers2, manager.number_of_buffers()); 172 EXPECT_EQ(kNumberOfBuffers2, manager.number_of_buffers());
173 EXPECT_EQ(kBufferSize2, manager.buffer_size()); 173 EXPECT_EQ(kBufferSize2, manager.buffer_size());
174 174
175 // Test DequeueBuffer() and GetBufferPointer() 175 // Test DequeueBuffer() and GetBufferPointer()
176 for (int32_t i = 0; i < kNumberOfBuffers2; ++i) { 176 for (int32_t i = 0; i < kNumberOfBuffers2; ++i) {
177 EXPECT_EQ(i, manager.DequeueBuffer()); 177 EXPECT_EQ(i, manager.DequeueBuffer());
178 EXPECT_EQ(reinterpret_cast<MediaStreamBuffer*>(memory + i * kBufferSize2), 178 EXPECT_EQ(reinterpret_cast<MediaStreamBuffer*>(memory + i * kBufferSize2),
179 manager.GetBufferPointer(i)); 179 manager.GetBufferPointer(i));
180 } 180 }
181 } 181 }
182 } 182 }
183 183
184 } // namespace ppapi 184 } // namespace ppapi
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698