Implement <appview> based on out-of-process iframes GuestView.

Implement <appview> based on out-of-process iframes GuestView.

BUG=601150
Committed: https://crrev.com/3f98529a283455bf1605ea72bbfa47598b8cbf3b
Cr-Commit-Position: refs/heads/master@{#386859}

[lfg, 2016-04-12 18:06:59]

lfg@chromium.org changed reviewers:
+ lazyboy@chromium.org, rdevlin.cronin@chromium.org

[lfg, 2016-04-12 18:07:00]

rdevlin.cronin@chromium.org: Please review changes in 

extensions/

lazyboy@chromium.org: Please review changes in 

guest_view/

[lazyboy, 2016-04-12 18:09:35]

https://codereview.chromium.org/1864283002/diff/20001/chrome/browser/apps/gue...
File chrome/browser/apps/guest_view/app_view_browsertest.cc (right):

https://codereview.chromium.org/1864283002/diff/20001/chrome/browser/apps/gue...
chrome/browser/apps/guest_view/app_view_browsertest.cc:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
What about app_view_apitest.cc, have you tried running them with OOPIF?

[Devlin, 2016-04-12 18:09:52]

https://codereview.chromium.org/1864283002/diff/20001/chrome/browser/apps/gue...
File chrome/browser/apps/guest_view/app_view_browsertest.cc (right):

https://codereview.chromium.org/1864283002/diff/20001/chrome/browser/apps/gue...
chrome/browser/apps/guest_view/app_view_browsertest.cc:170:
IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewRefusedDataShouldFail) {
Out of curiosity, is this significantly better than just running the tests on
the SiteIsolation trybot?  Is it worth making *all* the trybots run 7 extra
browser tests?

[lfg, 2016-04-12 20:53:38]

https://codereview.chromium.org/1864283002/diff/20001/chrome/browser/apps/gue...
File chrome/browser/apps/guest_view/app_view_browsertest.cc (right):

https://codereview.chromium.org/1864283002/diff/20001/chrome/browser/apps/gue...
chrome/browser/apps/guest_view/app_view_browsertest.cc:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2016/04/12 18:09:34, lazyboy wrote:
> What about app_view_apitest.cc, have you tried running them with OOPIF?

They all pass, but since they run on the unsupported app_shell test framework,
do you think it's worth maintaining it?

https://codereview.chromium.org/1864283002/diff/20001/chrome/browser/apps/gue...
chrome/browser/apps/guest_view/app_view_browsertest.cc:170:
IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewRefusedDataShouldFail) {
On 2016/04/12 18:09:52, Devlin wrote:
> Out of curiosity, is this significantly better than just running the tests on
> the SiteIsolation trybot?  Is it worth making *all* the trybots run 7 extra
> browser tests?

Yes, the SiteIsolation trybot tests with --site-per-process enabled, which is
different from --use-cross-process-frames-for-guests. This will test
--use-cross-process-frames-for-guests without --site-per-process, as well as
with --site-per-process (in the SiteIsolation trybots), so we get coverage for
all 4 possible modes.

(We did reach out to the infra team, and this was their recommendation over
adding another trybot).

[lfg, 2016-04-12 21:45:43]

Please, take another look.

https://codereview.chromium.org/1864283002/diff/20001/chrome/browser/apps/gue...
File chrome/browser/apps/guest_view/app_view_browsertest.cc (right):

https://codereview.chromium.org/1864283002/diff/20001/chrome/browser/apps/gue...
chrome/browser/apps/guest_view/app_view_browsertest.cc:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2016/04/12 18:09:34, lazyboy wrote:
> What about app_view_apitest.cc, have you tried running them with OOPIF?

I've enabled the tests.

[lazyboy, 2016-04-12 23:05:27]

lgtm.

[Devlin, 2016-04-12 23:06:17]

extensions lgtm

[lfg, 2016-04-12 23:19:04]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-04-12 23:19:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864283002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864283002/40001

[commit-bot: I haz the power, 2016-04-12 23:25:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-12 23:26:52]

Description was changed from

==========
Implement <appview> based on out-of-process iframes GuestView.

BUG=601150
==========

to

==========
Implement <appview> based on out-of-process iframes GuestView.

BUG=601150

Committed: https://crrev.com/3f98529a283455bf1605ea72bbfa47598b8cbf3b
Cr-Commit-Position: refs/heads/master@{#386859}
==========

[commit-bot: I haz the power, 2016-04-12 23:26:53]

Patchset 3 (id:??) landed as
https://crrev.com/3f98529a283455bf1605ea72bbfa47598b8cbf3b
Cr-Commit-Position: refs/heads/master@{#386859}