Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1864253002: Remove conditional flavor text on blend GM. (Closed)

Created:
4 years, 8 months ago by mtklein_C
Modified:
4 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove conditional flavor text on blend GM. This was breaking replay modes for no good reason. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864253002 Committed: https://skia.googlesource.com/skia/+/3d72c099c7341291e869099ef6c6600856ff24f8

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -256 lines) Patch
M gm/blend.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M tools/dm_flags.json View 1 30 chunks +0 lines, -240 lines 0 comments Download
M tools/dm_flags.py View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864253002/1
4 years, 8 months ago (2016-04-06 19:10:05 UTC) #3
mtklein_C
4 years, 8 months ago (2016-04-06 19:10:08 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 19:21:35 UTC) #7
reed1
lgtm
4 years, 8 months ago (2016-04-06 19:22:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864253002/20001
4 years, 8 months ago (2016-04-06 19:28:15 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 19:42:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3d72c099c7341291e869099ef6c6600856ff24f8

Powered by Google App Engine
This is Rietveld 408576698