Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

Issue 1864243002: Fix for issue 23861: CompletionSuggestion.parameterType are now populated. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Comments from DanR Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
index 9589874826fa03ce6252c3844e662fb9c6e18f71..72a57c7d76e4e9824bb54a0a3eff8682ba408e19 100644
--- a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
+++ b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
@@ -110,7 +110,9 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
bool isDeprecated: false,
bool isPotential: false,
String elemFile,
- int elemOffset}) {
+ int elemOffset,
+ String paramName,
+ String paramType}) {
CompletionSuggestion cs =
getSuggest(completion: completion, csKind: csKind, elemKind: elemKind);
if (cs == null) {
@@ -141,6 +143,12 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
if (elemOffset != null) {
expect(cs.element.location.offset, elemOffset);
}
+ if(paramName != null) {
+ expect(cs.parameterName, paramName);
+ }
+ if(paramType != null) {
+ expect(cs.parameterType, paramType);
+ }
return cs;
}
« no previous file with comments | « pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698