Fix for issue 23861: CompletionSuggestion.parameterType are now populated.

Fix for issue 23861: CompletionSuggestion.parameterType are now populated.

BUG=https://github.com/dart-lang/sdk/issues/23861
R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/3c8b0d20f360eb49f91819a9791fb1939639febb

[jwren, 2016-04-06 19:06:17]

jwren@google.com changed reviewers:
+ danrubel@google.com

[danrubel, 2016-04-06 19:16:58]

LGTM

https://codereview.chromium.org/1864243002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart
(right):

https://codereview.chromium.org/1864243002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart:273:
[String paramType = null]) {
Can this be changed from an optional parameter to a required parameter?

https://codereview.chromium.org/1864243002/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart
(right):

https://codereview.chromium.org/1864243002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart:83:
void assertSuggestArguments({List<String> namedArguments}) {
It would be better if all calls to this method were changed to call
assertSuggestArgumentsAndTypes instead... then remove this method. That way we
are asserting that paramType is correctly supplied everywhere.

[jwren, 2016-04-07 20:00:47]

https://codereview.chromium.org/1864243002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart
(right):

https://codereview.chromium.org/1864243002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart:273:
[String paramType = null]) {
On 2016/04/06 19:16:58, danrubel wrote:
> Can this be changed from an optional parameter to a required parameter?

Done.

https://codereview.chromium.org/1864243002/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart
(right):

https://codereview.chromium.org/1864243002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart:83:
void assertSuggestArguments({List<String> namedArguments}) {
On 2016/04/06 19:16:58, danrubel wrote:
> It would be better if all calls to this method were changed to call
> assertSuggestArgumentsAndTypes instead... then remove this method. That way we
> are asserting that paramType is correctly supplied everywhere.

Done.

[jwren, 2016-04-07 20:01:56]

Description was changed from

==========
Fix for issue 23861: CompletionSuggestion.parameterType are now populated.

BUG=https://github.com/dart-lang/sdk/issues/23861
==========

to

==========
Fix for issue 23861: CompletionSuggestion.parameterType are now populated.

BUG=https://github.com/dart-lang/sdk/issues/23861
R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3c8b0d20f360eb49f91819a9791fb1939639febb
==========

[jwren, 2016-04-07 20:01:58]

Committed patchset #2 (id:20001) manually as
3c8b0d20f360eb49f91819a9791fb1939639febb (presubmit successful).