Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: remoting/protocol/channel_multiplexer_unittest.cc

Issue 1864213002: Convert //remoting to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac IWYU Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/channel_multiplexer.cc ('k') | remoting/protocol/channel_socket_adapter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/channel_multiplexer_unittest.cc
diff --git a/remoting/protocol/channel_multiplexer_unittest.cc b/remoting/protocol/channel_multiplexer_unittest.cc
index 3f8729eaadea1c802c17f68adf3b64217c797c50..5e2efac18398ab713214260895e038352abce170 100644
--- a/remoting/protocol/channel_multiplexer_unittest.cc
+++ b/remoting/protocol/channel_multiplexer_unittest.cc
@@ -48,7 +48,7 @@ class MockSocketCallback {
class MockConnectCallback {
public:
MOCK_METHOD1(OnConnectedPtr, void(P2PStreamSocket* socket));
- void OnConnected(scoped_ptr<P2PStreamSocket> socket) {
+ void OnConnected(std::unique_ptr<P2PStreamSocket> socket) {
OnConnectedPtr(socket.release());
}
};
@@ -86,8 +86,8 @@ class ChannelMultiplexerTest : public testing::Test {
}
void CreateChannel(const std::string& name,
- scoped_ptr<P2PStreamSocket>* host_socket,
- scoped_ptr<P2PStreamSocket>* client_socket) {
+ std::unique_ptr<P2PStreamSocket>* host_socket,
+ std::unique_ptr<P2PStreamSocket>* client_socket) {
int counter = 2;
host_mux_->CreateChannel(name, base::Bind(
&ChannelMultiplexerTest::OnChannelConnected, base::Unretained(this),
@@ -102,10 +102,9 @@ class ChannelMultiplexerTest : public testing::Test {
EXPECT_TRUE(client_socket->get());
}
- void OnChannelConnected(
- scoped_ptr<P2PStreamSocket>* storage,
- int* counter,
- scoped_ptr<P2PStreamSocket> socket) {
+ void OnChannelConnected(std::unique_ptr<P2PStreamSocket>* storage,
+ int* counter,
+ std::unique_ptr<P2PStreamSocket> socket) {
*storage = std::move(socket);
--(*counter);
EXPECT_GE(*counter, 0);
@@ -127,19 +126,19 @@ class ChannelMultiplexerTest : public testing::Test {
FakeStreamChannelFactory host_channel_factory_;
FakeStreamChannelFactory client_channel_factory_;
- scoped_ptr<ChannelMultiplexer> host_mux_;
- scoped_ptr<ChannelMultiplexer> client_mux_;
+ std::unique_ptr<ChannelMultiplexer> host_mux_;
+ std::unique_ptr<ChannelMultiplexer> client_mux_;
- scoped_ptr<P2PStreamSocket> host_socket1_;
- scoped_ptr<P2PStreamSocket> client_socket1_;
- scoped_ptr<P2PStreamSocket> host_socket2_;
- scoped_ptr<P2PStreamSocket> client_socket2_;
+ std::unique_ptr<P2PStreamSocket> host_socket1_;
+ std::unique_ptr<P2PStreamSocket> client_socket1_;
+ std::unique_ptr<P2PStreamSocket> host_socket2_;
+ std::unique_ptr<P2PStreamSocket> client_socket2_;
};
TEST_F(ChannelMultiplexerTest, OneChannel) {
- scoped_ptr<P2PStreamSocket> host_socket;
- scoped_ptr<P2PStreamSocket> client_socket;
+ std::unique_ptr<P2PStreamSocket> host_socket;
+ std::unique_ptr<P2PStreamSocket> client_socket;
ASSERT_NO_FATAL_FAILURE(
CreateChannel(kTestChannelName, &host_socket, &client_socket));
@@ -151,13 +150,13 @@ TEST_F(ChannelMultiplexerTest, OneChannel) {
}
TEST_F(ChannelMultiplexerTest, TwoChannels) {
- scoped_ptr<P2PStreamSocket> host_socket1_;
- scoped_ptr<P2PStreamSocket> client_socket1_;
+ std::unique_ptr<P2PStreamSocket> host_socket1_;
+ std::unique_ptr<P2PStreamSocket> client_socket1_;
ASSERT_NO_FATAL_FAILURE(
CreateChannel(kTestChannelName, &host_socket1_, &client_socket1_));
- scoped_ptr<P2PStreamSocket> host_socket2_;
- scoped_ptr<P2PStreamSocket> client_socket2_;
+ std::unique_ptr<P2PStreamSocket> host_socket2_;
+ std::unique_ptr<P2PStreamSocket> client_socket2_;
ASSERT_NO_FATAL_FAILURE(
CreateChannel(kTestChannelName2, &host_socket2_, &client_socket2_));
@@ -176,23 +175,23 @@ TEST_F(ChannelMultiplexerTest, TwoChannels) {
// Four channels, two in each direction
TEST_F(ChannelMultiplexerTest, FourChannels) {
- scoped_ptr<P2PStreamSocket> host_socket1_;
- scoped_ptr<P2PStreamSocket> client_socket1_;
+ std::unique_ptr<P2PStreamSocket> host_socket1_;
+ std::unique_ptr<P2PStreamSocket> client_socket1_;
ASSERT_NO_FATAL_FAILURE(
CreateChannel(kTestChannelName, &host_socket1_, &client_socket1_));
- scoped_ptr<P2PStreamSocket> host_socket2_;
- scoped_ptr<P2PStreamSocket> client_socket2_;
+ std::unique_ptr<P2PStreamSocket> host_socket2_;
+ std::unique_ptr<P2PStreamSocket> client_socket2_;
ASSERT_NO_FATAL_FAILURE(
CreateChannel(kTestChannelName2, &host_socket2_, &client_socket2_));
- scoped_ptr<P2PStreamSocket> host_socket3;
- scoped_ptr<P2PStreamSocket> client_socket3;
+ std::unique_ptr<P2PStreamSocket> host_socket3;
+ std::unique_ptr<P2PStreamSocket> client_socket3;
ASSERT_NO_FATAL_FAILURE(
CreateChannel("test3", &host_socket3, &client_socket3));
- scoped_ptr<P2PStreamSocket> host_socket4;
- scoped_ptr<P2PStreamSocket> client_socket4;
+ std::unique_ptr<P2PStreamSocket> host_socket4;
+ std::unique_ptr<P2PStreamSocket> client_socket4;
ASSERT_NO_FATAL_FAILURE(
CreateChannel("ch4", &host_socket4, &client_socket4));
@@ -219,13 +218,13 @@ TEST_F(ChannelMultiplexerTest, FourChannels) {
}
TEST_F(ChannelMultiplexerTest, WriteFailSync) {
- scoped_ptr<P2PStreamSocket> host_socket1_;
- scoped_ptr<P2PStreamSocket> client_socket1_;
+ std::unique_ptr<P2PStreamSocket> host_socket1_;
+ std::unique_ptr<P2PStreamSocket> client_socket1_;
ASSERT_NO_FATAL_FAILURE(
CreateChannel(kTestChannelName, &host_socket1_, &client_socket1_));
- scoped_ptr<P2PStreamSocket> host_socket2_;
- scoped_ptr<P2PStreamSocket> client_socket2_;
+ std::unique_ptr<P2PStreamSocket> host_socket2_;
+ std::unique_ptr<P2PStreamSocket> client_socket2_;
ASSERT_NO_FATAL_FAILURE(
CreateChannel(kTestChannelName2, &host_socket2_, &client_socket2_));
« no previous file with comments | « remoting/protocol/channel_multiplexer.cc ('k') | remoting/protocol/channel_socket_adapter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698