remoting/protocol/message_serialization.h - Issue 1864213002: Convert //remoting to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/message_serialization.h

Issue 1864213002: Convert //remoting to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac IWYU Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/message_serialization.h

diff --git a/remoting/protocol/message_serialization.h b/remoting/protocol/message_serialization.h

index 2a035ff5101e57870d0e448813ef766b136b0029..cebc5aafb8fae33471b013700726013f84e59fb7 100644

--- a/remoting/protocol/message_serialization.h

+++ b/remoting/protocol/message_serialization.h

@@ -21,8 +21,8 @@ namespace remoting {

namespace protocol {

template <class T>

-scoped_ptr<T> ParseMessage(CompoundBuffer* buffer) {

- scoped_ptr<T> message(new T());

+std::unique_ptr<T> ParseMessage(CompoundBuffer* buffer) {

+ std::unique_ptr<T> message(new T());

CompoundBufferInputStream stream(buffer);

if (!message->ParseFromZeroCopyStream(&stream)) {

LOG(WARNING) << "Received message that is not a valid protocol buffer.";