Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: remoting/host/desktop_session_agent.cc

Issue 1864213002: Convert //remoting to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac IWYU Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/desktop_session_agent.h ('k') | remoting/host/desktop_session_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/desktop_session_agent.cc
diff --git a/remoting/host/desktop_session_agent.cc b/remoting/host/desktop_session_agent.cc
index 274bd2aae7794a4fbd6fec1c850d18a4133fc079..26ee9e1a9d98754daffb3b9e334cd0edbce43c02 100644
--- a/remoting/host/desktop_session_agent.cc
+++ b/remoting/host/desktop_session_agent.cc
@@ -9,6 +9,7 @@
#include "base/files/file_util.h"
#include "base/logging.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/memory/shared_memory.h"
#include "base/process/process_handle.h"
#include "build/build_config.h"
@@ -70,12 +71,12 @@ void DesktopSessionClipboardStub::InjectClipboardEvent(
// webrtc::SharedMemory implementation that creates base::SharedMemory.
class SharedMemoryImpl : public webrtc::SharedMemory {
public:
- static scoped_ptr<SharedMemoryImpl>
+ static std::unique_ptr<SharedMemoryImpl>
Create(size_t size, int id, const base::Closure& on_deleted_callback) {
- scoped_ptr<base::SharedMemory> memory(new base::SharedMemory());
+ std::unique_ptr<base::SharedMemory> memory(new base::SharedMemory());
if (!memory->CreateAndMapAnonymous(size))
return nullptr;
- return make_scoped_ptr(
+ return base::WrapUnique(
new SharedMemoryImpl(std::move(memory), size, id, on_deleted_callback));
}
@@ -84,7 +85,7 @@ class SharedMemoryImpl : public webrtc::SharedMemory {
base::SharedMemory* shared_memory() { return shared_memory_.get(); }
private:
- SharedMemoryImpl(scoped_ptr<base::SharedMemory> memory,
+ SharedMemoryImpl(std::unique_ptr<base::SharedMemory> memory,
size_t size,
int id,
const base::Closure& on_deleted_callback)
@@ -102,14 +103,14 @@ class SharedMemoryImpl : public webrtc::SharedMemory {
}
base::Closure on_deleted_callback_;
- scoped_ptr<base::SharedMemory> shared_memory_;
+ std::unique_ptr<base::SharedMemory> shared_memory_;
DISALLOW_COPY_AND_ASSIGN(SharedMemoryImpl);
};
class SharedMemoryFactoryImpl : public webrtc::SharedMemoryFactory {
public:
- typedef base::Callback<void(scoped_ptr<IPC::Message> message)>
+ typedef base::Callback<void(std::unique_ptr<IPC::Message> message)>
SendMessageCallback;
SharedMemoryFactoryImpl(const SendMessageCallback& send_message_callback)
@@ -117,12 +118,12 @@ class SharedMemoryFactoryImpl : public webrtc::SharedMemoryFactory {
rtc::scoped_ptr<webrtc::SharedMemory> CreateSharedMemory(
size_t size) override {
- base::Closure release_buffer_callback = base::Bind(
- send_message_callback_,
- base::Passed(
- make_scoped_ptr(new ChromotingDesktopNetworkMsg_ReleaseSharedBuffer(
- next_shared_buffer_id_))));
- scoped_ptr<SharedMemoryImpl> buffer = SharedMemoryImpl::Create(
+ base::Closure release_buffer_callback =
+ base::Bind(send_message_callback_,
+ base::Passed(base::WrapUnique(
+ new ChromotingDesktopNetworkMsg_ReleaseSharedBuffer(
+ next_shared_buffer_id_))));
+ std::unique_ptr<SharedMemoryImpl> buffer = SharedMemoryImpl::Create(
size, next_shared_buffer_id_, release_buffer_callback);
if (buffer) {
// |next_shared_buffer_id_| starts from 1 and incrementing it by 2 makes
@@ -136,7 +137,7 @@ class SharedMemoryFactoryImpl : public webrtc::SharedMemoryFactory {
next_shared_buffer_id_ += 2;
send_message_callback_.Run(
- make_scoped_ptr(new ChromotingDesktopNetworkMsg_CreateSharedBuffer(
+ base::WrapUnique(new ChromotingDesktopNetworkMsg_CreateSharedBuffer(
buffer->id(), buffer->shared_memory()->handle(),
buffer->size())));
}
@@ -235,7 +236,7 @@ const std::string& DesktopSessionAgent::client_jid() const {
}
void DesktopSessionAgent::DisconnectSession(protocol::ErrorCode error) {
- SendToNetwork(make_scoped_ptr(
+ SendToNetwork(base::WrapUnique(
new ChromotingDesktopNetworkMsg_DisconnectSession(error)));
}
@@ -294,7 +295,7 @@ void DesktopSessionAgent::OnStartSessionAgent(
#endif // defined(OS_WIN)
// Start the input injector.
- scoped_ptr<protocol::ClipboardStub> clipboard_stub(
+ std::unique_ptr<protocol::ClipboardStub> clipboard_stub(
new DesktopSessionClipboardStub(this));
input_injector_->Start(std::move(clipboard_stub));
@@ -334,16 +335,16 @@ void DesktopSessionAgent::OnCaptureCompleted(webrtc::DesktopFrame* frame) {
serialized_frame.dirty_region.push_back(i.rect());
}
- SendToNetwork(make_scoped_ptr(
+ SendToNetwork(base::WrapUnique(
new ChromotingDesktopNetworkMsg_CaptureCompleted(serialized_frame)));
}
void DesktopSessionAgent::OnMouseCursor(webrtc::MouseCursor* cursor) {
DCHECK(caller_task_runner_->BelongsToCurrentThread());
- scoped_ptr<webrtc::MouseCursor> owned_cursor(cursor);
+ std::unique_ptr<webrtc::MouseCursor> owned_cursor(cursor);
- SendToNetwork(make_scoped_ptr(
+ SendToNetwork(base::WrapUnique(
new ChromotingDesktopNetworkMsg_MouseCursor(*owned_cursor)));
}
@@ -364,11 +365,12 @@ void DesktopSessionAgent::InjectClipboardEvent(
return;
}
- SendToNetwork(make_scoped_ptr(
+ SendToNetwork(base::WrapUnique(
new ChromotingDesktopNetworkMsg_InjectClipboardEvent(serialized_event)));
}
-void DesktopSessionAgent::ProcessAudioPacket(scoped_ptr<AudioPacket> packet) {
+void DesktopSessionAgent::ProcessAudioPacket(
+ std::unique_ptr<AudioPacket> packet) {
DCHECK(audio_capture_task_runner_->BelongsToCurrentThread());
std::string serialized_packet;
@@ -377,7 +379,7 @@ void DesktopSessionAgent::ProcessAudioPacket(scoped_ptr<AudioPacket> packet) {
return;
}
- SendToNetwork(make_scoped_ptr(
+ SendToNetwork(base::WrapUnique(
new ChromotingDesktopNetworkMsg_AudioPacket(serialized_packet)));
}
@@ -545,7 +547,7 @@ void DesktopSessionAgent::SetScreenResolution(
screen_controls_->SetScreenResolution(resolution);
}
-void DesktopSessionAgent::SendToNetwork(scoped_ptr<IPC::Message> message) {
+void DesktopSessionAgent::SendToNetwork(std::unique_ptr<IPC::Message> message) {
if (!caller_task_runner_->BelongsToCurrentThread()) {
caller_task_runner_->PostTask(
FROM_HERE, base::Bind(&DesktopSessionAgent::SendToNetwork, this,
« no previous file with comments | « remoting/host/desktop_session_agent.h ('k') | remoting/host/desktop_session_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698