Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: remoting/host/pairing_registry_delegate_win.cc

Issue 1864213002: Convert //remoting to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac IWYU Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/pairing_registry_delegate_win.cc
diff --git a/remoting/host/pairing_registry_delegate_win.cc b/remoting/host/pairing_registry_delegate_win.cc
index d65014e5674ecc00247adf057e5ec9b1d09199fb..d2423c836e2d25c00e58f9b7e866924603ae3650 100644
--- a/remoting/host/pairing_registry_delegate_win.cc
+++ b/remoting/host/pairing_registry_delegate_win.cc
@@ -8,6 +8,7 @@
#include "base/json/json_string_value_serializer.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "base/win/registry.h"
@@ -38,8 +39,8 @@ bool DuplicateKeyHandle(HKEY source, base::win::RegKey* dest) {
// Reads value |value_name| from |key| as a JSON string and returns it as
// |base::Value|.
-scoped_ptr<base::DictionaryValue> ReadValue(const base::win::RegKey& key,
- const wchar_t* value_name) {
+std::unique_ptr<base::DictionaryValue> ReadValue(const base::win::RegKey& key,
+ const wchar_t* value_name) {
// presubmit: allow wstring
std::wstring value_json;
LONG result = key.ReadValue(value_name, &value_json);
@@ -54,7 +55,7 @@ scoped_ptr<base::DictionaryValue> ReadValue(const base::win::RegKey& key,
JSONStringValueDeserializer deserializer(value_json_utf8);
int error_code;
std::string error_message;
- scoped_ptr<base::Value> value =
+ std::unique_ptr<base::Value> value =
deserializer.Deserialize(&error_code, &error_message);
if (!value) {
LOG(ERROR) << "Failed to parse '" << value_name << "': " << error_message
@@ -67,14 +68,14 @@ scoped_ptr<base::DictionaryValue> ReadValue(const base::win::RegKey& key,
return nullptr;
}
- return make_scoped_ptr(static_cast<base::DictionaryValue*>(value.release()));
+ return base::WrapUnique(static_cast<base::DictionaryValue*>(value.release()));
}
// Serializes |value| into a JSON string and writes it as value |value_name|
// under |key|.
bool WriteValue(base::win::RegKey& key,
const wchar_t* value_name,
- scoped_ptr<base::DictionaryValue> value) {
+ std::unique_ptr<base::DictionaryValue> value) {
std::string value_json_utf8;
JSONStringValueSerializer serializer(&value_json_utf8);
if (!serializer.Serialize(*value)) {
@@ -121,8 +122,8 @@ bool PairingRegistryDelegateWin::SetRootKeys(HKEY privileged,
return true;
}
-scoped_ptr<base::ListValue> PairingRegistryDelegateWin::LoadAll() {
- scoped_ptr<base::ListValue> pairings(new base::ListValue());
+std::unique_ptr<base::ListValue> PairingRegistryDelegateWin::LoadAll() {
+ std::unique_ptr<base::ListValue> pairings(new base::ListValue());
// Enumerate and parse all values under the unprivileged key.
DWORD count = unprivileged_.GetValueCount();
@@ -186,15 +187,15 @@ PairingRegistry::Pairing PairingRegistryDelegateWin::Load(
std::wstring value_name = base::UTF8ToWide(client_id);
// Read unprivileged fields first.
- scoped_ptr<base::DictionaryValue> pairing = ReadValue(unprivileged_,
- value_name.c_str());
+ std::unique_ptr<base::DictionaryValue> pairing =
+ ReadValue(unprivileged_, value_name.c_str());
if (!pairing)
return PairingRegistry::Pairing();
// Read the shared secret.
if (privileged_.Valid()) {
- scoped_ptr<base::DictionaryValue> secret = ReadValue(privileged_,
- value_name.c_str());
+ std::unique_ptr<base::DictionaryValue> secret =
+ ReadValue(privileged_, value_name.c_str());
if (!secret)
return PairingRegistry::Pairing();
@@ -213,12 +214,13 @@ bool PairingRegistryDelegateWin::Save(const PairingRegistry::Pairing& pairing) {
}
// Convert pairing to JSON.
- scoped_ptr<base::DictionaryValue> pairing_json = pairing.ToValue();
+ std::unique_ptr<base::DictionaryValue> pairing_json = pairing.ToValue();
// Extract the shared secret to a separate dictionary.
- scoped_ptr<base::Value> secret_key;
+ std::unique_ptr<base::Value> secret_key;
CHECK(pairing_json->Remove(PairingRegistry::kSharedSecretKey, &secret_key));
- scoped_ptr<base::DictionaryValue> secret_json(new base::DictionaryValue());
+ std::unique_ptr<base::DictionaryValue> secret_json(
+ new base::DictionaryValue());
secret_json->Set(PairingRegistry::kSharedSecretKey, secret_key.release());
// presubmit: allow wstring
@@ -263,8 +265,8 @@ bool PairingRegistryDelegateWin::Delete(const std::string& client_id) {
return true;
}
-scoped_ptr<PairingRegistry::Delegate> CreatePairingRegistryDelegate() {
- return make_scoped_ptr(new PairingRegistryDelegateWin());
+std::unique_ptr<PairingRegistry::Delegate> CreatePairingRegistryDelegate() {
+ return base::WrapUnique(new PairingRegistryDelegateWin());
}
} // namespace remoting
« no previous file with comments | « remoting/host/pairing_registry_delegate_win.h ('k') | remoting/host/pairing_registry_delegate_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698