Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Unified Diff: remoting/signaling/xmpp_signal_strategy.cc

Issue 1864213002: Convert //remoting to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac IWYU Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/signaling/xmpp_signal_strategy.h ('k') | remoting/signaling/xmpp_signal_strategy_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/signaling/xmpp_signal_strategy.cc
diff --git a/remoting/signaling/xmpp_signal_strategy.cc b/remoting/signaling/xmpp_signal_strategy.cc
index 10aea02a1ddad8ae266348d82b6aaf594c4681d9..4e0ff698a112774c3c27e5165370863b45f57c97 100644
--- a/remoting/signaling/xmpp_signal_strategy.cc
+++ b/remoting/signaling/xmpp_signal_strategy.cc
@@ -67,7 +67,7 @@ class XmppSignalStrategy::Core : public XmppLoginHandler::Delegate {
std::string GetLocalJid() const;
void AddListener(Listener* listener);
void RemoveListener(Listener* listener);
- bool SendStanza(scoped_ptr<buzz::XmlElement> stanza);
+ bool SendStanza(std::unique_ptr<buzz::XmlElement> stanza);
void SetAuthInfo(const std::string& username,
const std::string& auth_token);
@@ -99,14 +99,14 @@ class XmppSignalStrategy::Core : public XmppLoginHandler::Delegate {
void SendMessage(const std::string& message) override;
void StartTls() override;
void OnHandshakeDone(const std::string& jid,
- scoped_ptr<XmppStreamParser> parser) override;
+ std::unique_ptr<XmppStreamParser> parser) override;
void OnLoginHandlerError(SignalStrategy::Error error) override;
// Callback for BufferedSocketWriter.
void OnMessageSent();
// Event handlers for XmppStreamParser.
- void OnStanza(const scoped_ptr<buzz::XmlElement> stanza);
+ void OnStanza(const std::unique_ptr<buzz::XmlElement> stanza);
void OnParserError();
void OnNetworkError(int error);
@@ -118,19 +118,19 @@ class XmppSignalStrategy::Core : public XmppLoginHandler::Delegate {
XmppServerConfig xmpp_server_config_;
// Used by the |socket_|.
- scoped_ptr<net::CertVerifier> cert_verifier_;
- scoped_ptr<net::TransportSecurityState> transport_security_state_;
+ std::unique_ptr<net::CertVerifier> cert_verifier_;
+ std::unique_ptr<net::TransportSecurityState> transport_security_state_;
- scoped_ptr<net::StreamSocket> socket_;
- scoped_ptr<BufferedSocketWriter> writer_;
+ std::unique_ptr<net::StreamSocket> socket_;
+ std::unique_ptr<BufferedSocketWriter> writer_;
int pending_writes_ = 0;
scoped_refptr<net::IOBuffer> read_buffer_;
bool read_pending_ = false;
TlsState tls_state_ = TlsState::NOT_REQUESTED;
- scoped_ptr<XmppLoginHandler> login_handler_;
- scoped_ptr<XmppStreamParser> stream_parser_;
+ std::unique_ptr<XmppLoginHandler> login_handler_;
+ std::unique_ptr<XmppStreamParser> stream_parser_;
std::string jid_;
Error error_ = OK;
@@ -236,7 +236,8 @@ void XmppSignalStrategy::Core::RemoveListener(Listener* listener) {
listeners_.RemoveObserver(listener);
}
-bool XmppSignalStrategy::Core::SendStanza(scoped_ptr<buzz::XmlElement> stanza) {
+bool XmppSignalStrategy::Core::SendStanza(
+ std::unique_ptr<buzz::XmlElement> stanza) {
DCHECK(thread_checker_.CalledOnValidThread());
if (!stream_parser_) {
@@ -288,7 +289,7 @@ void XmppSignalStrategy::Core::StartTls() {
DCHECK(!read_pending_);
- scoped_ptr<net::ClientSocketHandle> socket_handle(
+ std::unique_ptr<net::ClientSocketHandle> socket_handle(
new net::ClientSocketHandle());
socket_handle->SetSocket(std::move(socket_));
@@ -311,7 +312,7 @@ void XmppSignalStrategy::Core::StartTls() {
void XmppSignalStrategy::Core::OnHandshakeDone(
const std::string& jid,
- scoped_ptr<XmppStreamParser> parser) {
+ std::unique_ptr<XmppStreamParser> parser) {
DCHECK(thread_checker_.CalledOnValidThread());
jid_ = jid;
@@ -345,7 +346,7 @@ void XmppSignalStrategy::Core::OnMessageSent() {
}
void XmppSignalStrategy::Core::OnStanza(
- const scoped_ptr<buzz::XmlElement> stanza) {
+ const std::unique_ptr<buzz::XmlElement> stanza) {
DCHECK(thread_checker_.CalledOnValidThread());
base::ObserverListBase<Listener>::Iterator it(&listeners_);
@@ -526,7 +527,7 @@ void XmppSignalStrategy::AddListener(Listener* listener) {
void XmppSignalStrategy::RemoveListener(Listener* listener) {
core_->RemoveListener(listener);
}
-bool XmppSignalStrategy::SendStanza(scoped_ptr<buzz::XmlElement> stanza) {
+bool XmppSignalStrategy::SendStanza(std::unique_ptr<buzz::XmlElement> stanza) {
return core_->SendStanza(std::move(stanza));
}
« no previous file with comments | « remoting/signaling/xmpp_signal_strategy.h ('k') | remoting/signaling/xmpp_signal_strategy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698