Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: remoting/protocol/session_config_unittest.cc

Issue 1864213002: Convert //remoting to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mac IWYU Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/protocol/session_config.cc ('k') | remoting/protocol/session_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/protocol/session_config.h" 5 #include "remoting/protocol/session_config.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace remoting { 9 namespace remoting {
10 namespace protocol { 10 namespace protocol {
11 11
12 void TestGetFinalConfig(scoped_ptr<SessionConfig> config) { 12 void TestGetFinalConfig(std::unique_ptr<SessionConfig> config) {
13 scoped_ptr<CandidateSessionConfig> candidate_config = 13 std::unique_ptr<CandidateSessionConfig> candidate_config =
14 CandidateSessionConfig::CreateFrom(*config); 14 CandidateSessionConfig::CreateFrom(*config);
15 ASSERT_TRUE(candidate_config); 15 ASSERT_TRUE(candidate_config);
16 scoped_ptr<SessionConfig> config2 = 16 std::unique_ptr<SessionConfig> config2 =
17 SessionConfig::GetFinalConfig(candidate_config.get()); 17 SessionConfig::GetFinalConfig(candidate_config.get());
18 ASSERT_TRUE(config2); 18 ASSERT_TRUE(config2);
19 EXPECT_EQ(config->protocol(), config2->protocol()); 19 EXPECT_EQ(config->protocol(), config2->protocol());
20 20
21 if (config->protocol() == SessionConfig::Protocol::ICE) { 21 if (config->protocol() == SessionConfig::Protocol::ICE) {
22 EXPECT_EQ(config->control_config(), config2->control_config()); 22 EXPECT_EQ(config->control_config(), config2->control_config());
23 EXPECT_EQ(config->event_config(), config2->event_config()); 23 EXPECT_EQ(config->event_config(), config2->event_config());
24 EXPECT_EQ(config->video_config(), config2->video_config()); 24 EXPECT_EQ(config->video_config(), config2->video_config());
25 EXPECT_EQ(config->audio_config(), config2->audio_config()); 25 EXPECT_EQ(config->audio_config(), config2->audio_config());
26 } 26 }
27 } 27 }
28 28
29 TEST(SessionConfig, SelectCommon) { 29 TEST(SessionConfig, SelectCommon) {
30 scoped_ptr<CandidateSessionConfig> default_candidate_config = 30 std::unique_ptr<CandidateSessionConfig> default_candidate_config =
31 CandidateSessionConfig::CreateDefault(); 31 CandidateSessionConfig::CreateDefault();
32 32
33 scoped_ptr<CandidateSessionConfig> candidate_config_with_webrtc = 33 std::unique_ptr<CandidateSessionConfig> candidate_config_with_webrtc =
34 CandidateSessionConfig::CreateEmpty(); 34 CandidateSessionConfig::CreateEmpty();
35 candidate_config_with_webrtc->set_webrtc_supported(true); 35 candidate_config_with_webrtc->set_webrtc_supported(true);
36 36
37 scoped_ptr<CandidateSessionConfig> hybrid_candidate_config = 37 std::unique_ptr<CandidateSessionConfig> hybrid_candidate_config =
38 CandidateSessionConfig::CreateDefault(); 38 CandidateSessionConfig::CreateDefault();
39 hybrid_candidate_config->set_webrtc_supported(true); 39 hybrid_candidate_config->set_webrtc_supported(true);
40 40
41 scoped_ptr<SessionConfig> selected; 41 std::unique_ptr<SessionConfig> selected;
42 42
43 // ICE is selected by default. 43 // ICE is selected by default.
44 selected = SessionConfig::SelectCommon(default_candidate_config.get(), 44 selected = SessionConfig::SelectCommon(default_candidate_config.get(),
45 default_candidate_config.get()); 45 default_candidate_config.get());
46 ASSERT_TRUE(selected); 46 ASSERT_TRUE(selected);
47 EXPECT_EQ(SessionConfig::Protocol::ICE, selected->protocol()); 47 EXPECT_EQ(SessionConfig::Protocol::ICE, selected->protocol());
48 48
49 // WebRTC protocol is not supported by default. 49 // WebRTC protocol is not supported by default.
50 selected = SessionConfig::SelectCommon(default_candidate_config.get(), 50 selected = SessionConfig::SelectCommon(default_candidate_config.get(),
51 candidate_config_with_webrtc.get()); 51 candidate_config_with_webrtc.get());
(...skipping 23 matching lines...) Expand all
75 ASSERT_TRUE(selected); 75 ASSERT_TRUE(selected);
76 EXPECT_EQ(SessionConfig::Protocol::WEBRTC, selected->protocol()); 76 EXPECT_EQ(SessionConfig::Protocol::WEBRTC, selected->protocol());
77 } 77 }
78 78
79 TEST(SessionConfig, GetFinalConfig) { 79 TEST(SessionConfig, GetFinalConfig) {
80 TestGetFinalConfig(SessionConfig::ForTest()); 80 TestGetFinalConfig(SessionConfig::ForTest());
81 TestGetFinalConfig(SessionConfig::ForTestWithWebrtc()); 81 TestGetFinalConfig(SessionConfig::ForTestWithWebrtc());
82 } 82 }
83 83
84 TEST(SessionConfig, IsSupported) { 84 TEST(SessionConfig, IsSupported) {
85 scoped_ptr<CandidateSessionConfig> default_candidate_config = 85 std::unique_ptr<CandidateSessionConfig> default_candidate_config =
86 CandidateSessionConfig::CreateDefault(); 86 CandidateSessionConfig::CreateDefault();
87 87
88 scoped_ptr<CandidateSessionConfig> candidate_config_with_webrtc = 88 std::unique_ptr<CandidateSessionConfig> candidate_config_with_webrtc =
89 CandidateSessionConfig::CreateEmpty(); 89 CandidateSessionConfig::CreateEmpty();
90 candidate_config_with_webrtc->set_webrtc_supported(true); 90 candidate_config_with_webrtc->set_webrtc_supported(true);
91 91
92 scoped_ptr<CandidateSessionConfig> hybrid_candidate_config = 92 std::unique_ptr<CandidateSessionConfig> hybrid_candidate_config =
93 CandidateSessionConfig::CreateDefault(); 93 CandidateSessionConfig::CreateDefault();
94 hybrid_candidate_config->set_webrtc_supported(true); 94 hybrid_candidate_config->set_webrtc_supported(true);
95 95
96 scoped_ptr<SessionConfig> ice_config = SessionConfig::ForTest(); 96 std::unique_ptr<SessionConfig> ice_config = SessionConfig::ForTest();
97 scoped_ptr<SessionConfig> webrtc_config = SessionConfig::ForTestWithWebrtc(); 97 std::unique_ptr<SessionConfig> webrtc_config =
98 SessionConfig::ForTestWithWebrtc();
98 99
99 EXPECT_TRUE(default_candidate_config->IsSupported(*ice_config)); 100 EXPECT_TRUE(default_candidate_config->IsSupported(*ice_config));
100 EXPECT_FALSE(default_candidate_config->IsSupported(*webrtc_config)); 101 EXPECT_FALSE(default_candidate_config->IsSupported(*webrtc_config));
101 102
102 EXPECT_FALSE(candidate_config_with_webrtc->IsSupported(*ice_config)); 103 EXPECT_FALSE(candidate_config_with_webrtc->IsSupported(*ice_config));
103 EXPECT_TRUE(candidate_config_with_webrtc->IsSupported(*webrtc_config)); 104 EXPECT_TRUE(candidate_config_with_webrtc->IsSupported(*webrtc_config));
104 105
105 EXPECT_TRUE(hybrid_candidate_config->IsSupported(*ice_config)); 106 EXPECT_TRUE(hybrid_candidate_config->IsSupported(*ice_config));
106 EXPECT_TRUE(hybrid_candidate_config->IsSupported(*webrtc_config)); 107 EXPECT_TRUE(hybrid_candidate_config->IsSupported(*webrtc_config));
107 } 108 }
108 109
109 } // namespace protocol 110 } // namespace protocol
110 } // namespace remoting 111 } // namespace remoting
OLDNEW
« no previous file with comments | « remoting/protocol/session_config.cc ('k') | remoting/protocol/session_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698