SkPDF: fix PDF/A

SkPDF:  fix PDF/A

TODO: get a bot to start testing this.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1864163004

Committed: https://skia.googlesource.com/skia/+/8cd4a24236ffc26522d0372c0d0ab0d96e301b3b

[hal.canary, 2016-04-06 22:37:37]

Description was changed from

==========
SkPDF:  fix PDF/A

TODO: get a bot to start testing this.

BUG=skia:
==========

to

==========
SkPDF:  fix PDF/A

TODO: get a bot to start testing this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-04-06 22:39:06]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 22:39:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864163004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864163004/1

[commit-bot: I haz the power, 2016-04-06 22:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 22:48:46]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-04-07 01:09:24]

halcanary@google.com changed reviewers:
+ tomhudson@google.com

[hal.canary, 2016-04-07 01:09:24]

ptal

[reed1, 2016-04-07 13:17:08]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-04-07 13:17:08]

will this become a runtime option instead of compiletime?

[hal.canary, 2016-04-07 13:20:14]

On 2016/04/07 13:17:08, reed1 wrote:
> will this become a runtime option instead of compiletime?

That's up to you. How do you want the API to look?

[reed1, 2016-04-07 13:41:12]

What are the advantages of each? Why did you initially chose compiletime?

[hal.canary, 2016-04-07 14:49:04]

On 2016/04/07 13:41:12, reed1 wrote:
> Why did you initially chose compiletime?

Neither Chrome nor Android wanted this feature.

> What are the advantages of each?

The disadvantage of runtime:

1.  Chrome and Android aren't using it now.

2.  I use src/utils/SkMD5.cpp to generate unique document ids.  Chrome doesn't
compile this now.

3.  About 300 additional LOC get compiled into SkPDF.

[tomhudson, 2016-04-07 15:47:32]

LGTM modulo Mike.

Personal weak preference is runtime selectability under the assumption that'd
make it easier to add the feature to Chrome/Android.

[hal.canary, 2016-04-07 15:54:53]

On 2016/04/07 15:47:32, tomhudson wrote:
> LGTM modulo Mike.
> 
> Personal weak preference is runtime selectability under the assumption that'd
> make it easier to add the feature to Chrome/Android.

I'm landing this, since it simple fixes existing behavior.  We can look at an
API for runtime switching later.

[hal.canary, 2016-04-07 15:54:58]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-04-07 15:55:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864163004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864163004/1

[commit-bot: I haz the power, 2016-04-07 15:56:18]

Description was changed from

==========
SkPDF:  fix PDF/A

TODO: get a bot to start testing this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkPDF:  fix PDF/A

TODO: get a bot to start testing this.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8cd4a24236ffc26522d0372c0d0ab0d96e301b3b
==========

[commit-bot: I haz the power, 2016-04-07 15:56:19]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8cd4a24236ffc26522d0372c0d0ab0d96e301b3b