Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1864153002: Move include/fxcodec to fxcodec/include (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -742 lines) Patch
M BUILD.gn View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_basic_module.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorspace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_image.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/codec_int.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_bmp.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_fax.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_flate.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxcodec/codec/fx_codec_gif.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_icc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_jbig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_jpeg.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_png.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_progress.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_progress.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_tiff.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + core/fxcodec/include/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + core/fxcodec/include/fx_codec.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + core/fxcodec/include/fx_codec_def.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fxcodec/include/fx_codec_flate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_Context.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/jbig2/JBig2_GrdProc.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/jbig2/JBig2_GrdProc.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/agg/fx_agg_driver.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/dib/fx_dib_composite.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/dib/fx_dib_convert.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/dib/fx_dib_main.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_ps.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_text.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
D core/include/fxcodec/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D core/include/fxcodec/fx_codec.h View 1 chunk +0 lines, -560 lines 0 comments Download
D core/include/fxcodec/fx_codec_def.h View 1 chunk +0 lines, -92 lines 0 comments Download
D core/include/fxcodec/fx_codec_flate.h View 1 chunk +0 lines, -33 lines 0 comments Download
M fpdfsdk/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/BC_BufferedImageLuminanceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
A xfa/fxbarcode/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/fxfa/app/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
A xfa/fxfa/parser/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A xfa/include/fxfa/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/include/fxfa/xfa_ffwidget.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-06 17:38:55 UTC) #2
Tom Sepez
https://codereview.chromium.org/1864153002/diff/1/core/fpdfapi/fpdf_page/cpdf_image.cpp File core/fpdfapi/fpdf_page/cpdf_image.cpp (right): https://codereview.chromium.org/1864153002/diff/1/core/fpdfapi/fpdf_page/cpdf_image.cpp#newcode19 core/fpdfapi/fpdf_page/cpdf_image.cpp:19: #include "core/fxcodec/include/fx_codec.h" sort order. https://codereview.chromium.org/1864153002/diff/1/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp File core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp (right): https://codereview.chromium.org/1864153002/diff/1/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp#newcode32 ...
4 years, 8 months ago (2016-04-06 17:42:33 UTC) #3
dsinclair
https://codereview.chromium.org/1864153002/diff/1/core/fpdfapi/fpdf_page/cpdf_image.cpp File core/fpdfapi/fpdf_page/cpdf_image.cpp (right): https://codereview.chromium.org/1864153002/diff/1/core/fpdfapi/fpdf_page/cpdf_image.cpp#newcode19 core/fpdfapi/fpdf_page/cpdf_image.cpp:19: #include "core/fxcodec/include/fx_codec.h" On 2016/04/06 17:42:32, Tom Sepez wrote: > ...
4 years, 8 months ago (2016-04-06 17:44:52 UTC) #4
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-06 19:10:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864153002/20001
4 years, 8 months ago (2016-04-06 19:11:49 UTC) #7
commit-bot: I haz the power
Failed to apply patch for fpdfsdk/DEPS: While running git apply --index -3 -p1; error: patch ...
4 years, 8 months ago (2016-04-06 19:12:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864153002/40001
4 years, 8 months ago (2016-04-06 19:18:28 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 19:30:35 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/86e5474dc4ff7fe0d0850f26f7320e1e57f3...

Powered by Google App Engine
This is Rietveld 408576698