components/mus/public/cpp/lib/window_tree_client_impl.h - Issue 1864113002: Fixes problems with drawn state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/cpp/lib/window_tree_client_impl.h

Issue 1864113002: Fixes problems with drawn state (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/mus/public/cpp/lib/window_private.h ('k') | components/mus/public/cpp/lib/window_tree_client_impl.cc » ('j') | components/mus/public/interfaces/window_tree.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/public/cpp/lib/window_tree_client_impl.h

diff --git a/components/mus/public/cpp/lib/window_tree_client_impl.h b/components/mus/public/cpp/lib/window_tree_client_impl.h

index df2140781c86f651521bce9af25128b87e564a50..01c168957d5e3b0076df3693fb7c7efe6aa05eff 100644

--- a/components/mus/public/cpp/lib/window_tree_client_impl.h

+++ b/components/mus/public/cpp/lib/window_tree_client_impl.h

@@ -156,7 +156,8 @@ class WindowTreeClientImpl : public WindowTreeConnection,

void OnEmbedImpl(mojom::WindowTree* window_tree,

ConnectionSpecificId connection_id,

mojom::WindowDataPtr root_data,

- Id focused_window_id);

+ Id focused_window_id,

+ bool drawn);

// Overridden from WindowTreeConnection:

void SetDeleteOnNoRoots(bool value) override;

@@ -174,12 +175,14 @@ class WindowTreeClientImpl : public WindowTreeConnection,

void OnEmbed(ConnectionSpecificId connection_id,

mojom::WindowDataPtr root,

mojom::WindowTreePtr tree,

- Id focused_window_id) override;

+ Id focused_window_id,

+ bool drawn) override;

void OnEmbeddedAppDisconnected(Id window_id) override;

void OnUnembed(Id window_id) override;

void OnLostCapture(Id window_id) override;

void OnTopLevelCreated(uint32_t change_id,

- mojom::WindowDataPtr data) override;

+ mojom::WindowDataPtr data,

+ bool drawn) override;

void OnWindowBoundsChanged(Id window_id,

mojo::RectPtr old_bounds,

mojo::RectPtr new_bounds) override;

@@ -205,7 +208,7 @@ class WindowTreeClientImpl : public WindowTreeConnection,

mojom::OrderDirection direction) override;

void OnWindowDeleted(Id window_id) override;

void OnWindowVisibilityChanged(Id window_id, bool visible) override;

- void OnWindowDrawnStateChanged(Id window_id, bool drawn) override;

+ void OnWindowParentDrawnStateChanged(Id window_id, bool drawn) override;

void OnWindowSharedPropertyChanged(Id window_id,

const mojo::String& name,

mojo::Array<uint8_t> new_data) override;