chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java - Issue 1864053002: Implement Android UI of web notification inline replies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

Issue 1864053002: Implement Android UI of web notification inline replies Base URL: https://chromium.googlesource.com/chromium/src.git@inline_replies_ps1

Patch Set: Fix filename? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | chrome/android/java/strings/android_chrome_strings.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

index e631071264bb40a8fe085c074a233775823e710b..48242f3baf566a842a395725e7ded21335385d1c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

@@ -31,10 +31,10 @@ public class StandardNotificationBuilder extends NotificationBuilderBase {

builder.setContentIntent(mContentIntent);

builder.setDeleteIntent(mDeleteIntent);

for (Action action : mActions) {

- addActionToBuilder(builder, action);

+ addActionToBuilder(builder, action, mDefaultPlaceholder);

}

if (mSettingsAction != null) {

- addActionToBuilder(builder, mSettingsAction);

+ addActionToBuilder(builder, mSettingsAction, mDefaultPlaceholder);

}

builder.setDefaults(mDefaults);

builder.setVibrate(mVibratePattern);