Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4230)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

Issue 1864053002: Implement Android UI of web notification inline replies Base URL: https://chromium.googlesource.com/chromium/src.git@inline_replies_ps1
Patch Set: Fix filename? Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
index 3c17745178f4f4808019d2c5eba6ccb738a54370..2e0e991913a3757ff992fa18cb5e17639faf4f87 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
@@ -139,10 +139,10 @@ public class CustomNotificationBuilder extends NotificationBuilderBase {
builder.setLargeIcon(mLargeIcon);
setSmallIconOnBuilder(builder, mSmallIconId, mSmallIconBitmap);
for (Action action : mActions) {
- addActionToBuilder(builder, action);
+ addActionToBuilder(builder, action, mDefaultPlaceholder);
}
if (mSettingsAction != null) {
- addActionToBuilder(builder, mSettingsAction);
+ addActionToBuilder(builder, mSettingsAction, null /* defaultPlaceholder */);
Michael van Ouwerkerk 2016/04/07 14:19:20 My point is that these basically identical calls a
}
Notification notification = builder.build();

Powered by Google App Engine
This is Rietveld 408576698