Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 186403004: Revert of Oilpan: Use the OilpanExpectations for oilpan specific test expectations. (Closed)

Created:
6 years, 9 months ago by Mads Ager (chromium)
Modified:
6 years, 9 months ago
CC:
blink-reviews, oilpan-reviews
Visibility:
Public.

Description

Revert of Oilpan: Use the OilpanExpectations for oilpan specific test expectations. (https://codereview.chromium.org/183683012/) Reason for revert: Only the release oilpan layout tests are run with the --additional-expectations flag. Reverting back to using TestExpectations for now. Original issue's description: > Oilpan: Use the OilpanExpectations for oilpan specific test expectations. > > R=erik.corry@gmail.com, haraken@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168366 TBR=erik.corry@gmail.com,haraken@chromium.org,wibling@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168378

Patch Set 1 #

Patch Set 2 : Fix patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M LayoutTests/OilpanExpectations View 1 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mads Ager (chromium)
Created Revert of Oilpan: Use the OilpanExpectations for oilpan specific test expectations.
6 years, 9 months ago (2014-03-04 11:00:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/186403004/1
6 years, 9 months ago (2014-03-04 11:00:33 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 11:00:39 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-04 11:00:41 UTC) #4
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-04 11:06:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/186403004/50001
6 years, 9 months ago (2014-03-04 11:07:16 UTC) #6
commit-bot: I haz the power
Change committed as 168378
6 years, 9 months ago (2014-03-04 11:08:08 UTC) #7
haraken
6 years, 9 months ago (2014-03-04 11:46:44 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698