Make font-related CSS properties less custom.

Make font-related CSS properties less custom.

Add a bit more smarts to StyleBuilder jinja machinery to make
it understand how fonts are made. Custom is bad. Generated is good.

R=ksakamoto@chromium.org,eae
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168522

[dglazkov, 2014-03-04 05:16:31]

+timloh, the jinja ninja.

[Timothy Loh, 2014-03-04 05:58:22]

lgtm! (I think nbarth is now the jinja ninja though after the bindings rewrite)

https://codereview.chromium.org/186403002/diff/1/Source/build/scripts/templat...
File Source/build/scripts/templates/StyleBuilder.cpp.tmpl (right):

https://codereview.chromium.org/186403002/diff/1/Source/build/scripts/templat...
Source/build/scripts/templates/StyleBuilder.cpp.tmpl:19: {%- endif %}
I'd probably put state.fontBuilder().{{property.setter}} here and reduce
copy-paste a tiny amount.

https://codereview.chromium.org/186403002/diff/1/Source/build/scripts/templat...
Source/build/scripts/templates/StyleBuilder.cpp.tmpl:60: if
(!value->isPrimitiveValue())
Can we see if removing this branch doesn't break anything? I think the early
returns like this in the StyleBuilder will only hide parser bugs. The
toCSSPrimitiveValue call should assert if we have a wrong value.

I've been meaning to go around and get rid of all these returns (and get rid of
oldApplyProperty!), but I haven't gotten around to it.

https://codereview.chromium.org/186403002/diff/1/Source/core/css/resolver/Fon...
File Source/core/css/resolver/FontBuilder.h (right):

https://codereview.chromium.org/186403002/diff/1/Source/core/css/resolver/Fon...
Source/core/css/resolver/FontBuilder.h:94: public:
Looks like we're already public.

[dglazkov, 2014-03-05 04:05:18]

Thanks for review!

https://codereview.chromium.org/186403002/diff/1/Source/build/scripts/templat...
File Source/build/scripts/templates/StyleBuilder.cpp.tmpl (right):

https://codereview.chromium.org/186403002/diff/1/Source/build/scripts/templat...
Source/build/scripts/templates/StyleBuilder.cpp.tmpl:19: {%- endif %}
Done.

https://codereview.chromium.org/186403002/diff/1/Source/build/scripts/templat...
Source/build/scripts/templates/StyleBuilder.cpp.tmpl:60: if
(!value->isPrimitiveValue())
On 2014/03/04 05:58:22, Timothy Loh wrote:
> Can we see if removing this branch doesn't break anything?

Will do next!

https://codereview.chromium.org/186403002/diff/1/Source/core/css/resolver/Fon...
File Source/core/css/resolver/FontBuilder.h (right):

https://codereview.chromium.org/186403002/diff/1/Source/core/css/resolver/Fon...
Source/core/css/resolver/FontBuilder.h:94: public:
On 2014/03/04 05:58:22, Timothy Loh wrote:
> Looks like we're already public.

Removed.

[dglazkov, 2014-03-05 04:08:47]

The CQ bit was checked by dglazkov@chromium.org

[commit-bot: I haz the power, 2014-03-05 04:09:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dglazkov@chromium.org/186403002/20001

[commit-bot: I haz the power, 2014-03-05 19:44:51]

Change committed as 168522