Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1864013002: [test] Fix windows nosnap test expectations. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix windows nosnap test expectations. Now that we pass all these tests, we need to update the test expectations. TBR=machenbach@chromium.org Committed: https://crrev.com/318d9f52fd968b1cc0bdc955843ab27abb7bacc4 Cr-Commit-Position: refs/heads/master@{#35295}

Patch Set 1 #

Patch Set 2 : All done! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-06 10:01:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864013002/1
4 years, 8 months ago (2016-04-06 10:02:13 UTC) #3
Michael Achenbach
Can it be that you miss a few? Note that the UI is showing only ...
4 years, 8 months ago (2016-04-06 10:11:20 UTC) #5
Michael Achenbach
On 2016/04/06 10:11:20, Michael Achenbach wrote: > Can it be that you miss a few? ...
4 years, 8 months ago (2016-04-06 10:12:32 UTC) #6
Michael Achenbach
cat stdio | grep "=== mjsunit" | sort | uniq | awk '{ print $2 ...
4 years, 8 months ago (2016-04-06 10:15:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864013002/20001
4 years, 8 months ago (2016-04-06 10:33:12 UTC) #9
Michael Achenbach
LGTM yea!
4 years, 8 months ago (2016-04-06 11:38:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 11:39:43 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/318d9f52fd968b1cc0bdc955843ab27abb7bacc4 Cr-Commit-Position: refs/heads/master@{#35295}
4 years, 8 months ago (2016-04-06 11:40:31 UTC) #13
Michael Achenbach
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/12736 But why???
4 years, 8 months ago (2016-04-06 12:30:39 UTC) #14
Michael Achenbach
4 years, 8 months ago (2016-04-06 12:34:46 UTC) #15
Message was sent while issue was closed.
On 2016/04/06 12:30:39, Michael Achenbach wrote:
>
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%2...
> 
> But why???

Seems to be a random-seed specific flake :/

Powered by Google App Engine
This is Rietveld 408576698