S390: Overflow check assert expanded to include kS390_Add/kS390_Sub

S390: Overflow check assert expanded to include kS390_Add/kS390_Sub

Debug asserts in code-generator-s390.cc are in place to ensure that overflow is only set when dealing with a sub or add opcode. However, the check only looked for kS390_Add/SubWithOverflow32, not kS390_Add/Sub which also sets overflow. This CL adds the second case to this assert check.

R=michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mtbrandyberry@ca.ibm.com,joransiu@ca.ibm.com

BUG=

Committed: https://crrev.com/960e25ea2ce3515f2ae5132c796a9b689f314168
Cr-Commit-Position: refs/heads/master@{#35310}

[john.yan, 2016-04-06 18:31:03]

lgtm

[bcleung, 2016-04-06 18:31:28]

Description was changed from

==========
S390: Overflow check assert expanded to include kS390_Add/kS390_Sub

R=michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mtbrandyberry@ca.ibm.com,joransiu...

BUG=
==========

to

==========
S390: Overflow check assert expanded to include kS390_Add/kS390_Sub

Debug asserts in code-generator-s390.cc are in place to ensure that overflow is
only set when dealing with a sub or add opcode. However, the check only looked
for kS390_Add/SubWithOverflow32, not kS390_Add/Sub which also sets overflow.
This CL adds the second case to this assert check.

R=michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mtbrandyberry@ca.ibm.com,joransiu...

BUG=
==========

[bcleung, 2016-04-06 18:31:41]

The CQ bit was checked by bryleun@ca.ibm.com

[commit-bot: I haz the power, 2016-04-06 18:31:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863983003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863983003/1

[commit-bot: I haz the power, 2016-04-06 18:49:56]

Description was changed from

==========
S390: Overflow check assert expanded to include kS390_Add/kS390_Sub

Debug asserts in code-generator-s390.cc are in place to ensure that overflow is
only set when dealing with a sub or add opcode. However, the check only looked
for kS390_Add/SubWithOverflow32, not kS390_Add/Sub which also sets overflow.
This CL adds the second case to this assert check.

R=michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mtbrandyberry@ca.ibm.com,joransiu...

BUG=
==========

to

==========
S390: Overflow check assert expanded to include kS390_Add/kS390_Sub

Debug asserts in code-generator-s390.cc are in place to ensure that overflow is
only set when dealing with a sub or add opcode. However, the check only looked
for kS390_Add/SubWithOverflow32, not kS390_Add/Sub which also sets overflow.
This CL adds the second case to this assert check.

R=michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mtbrandyberry@ca.ibm.com,joransiu...

BUG=
==========

[commit-bot: I haz the power, 2016-04-06 18:49:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-06 18:51:00]

Description was changed from

==========
S390: Overflow check assert expanded to include kS390_Add/kS390_Sub

Debug asserts in code-generator-s390.cc are in place to ensure that overflow is
only set when dealing with a sub or add opcode. However, the check only looked
for kS390_Add/SubWithOverflow32, not kS390_Add/Sub which also sets overflow.
This CL adds the second case to this assert check.

R=michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mtbrandyberry@ca.ibm.com,joransiu...

BUG=
==========

to

==========
S390: Overflow check assert expanded to include kS390_Add/kS390_Sub

Debug asserts in code-generator-s390.cc are in place to ensure that overflow is
only set when dealing with a sub or add opcode. However, the check only looked
for kS390_Add/SubWithOverflow32, not kS390_Add/Sub which also sets overflow.
This CL adds the second case to this assert check.

R=michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mtbrandyberry@ca.ibm.com,joransiu...

BUG=

Committed: https://crrev.com/960e25ea2ce3515f2ae5132c796a9b689f314168
Cr-Commit-Position: refs/heads/master@{#35310}
==========

[commit-bot: I haz the power, 2016-04-06 18:51:01]

Patchset 1 (id:??) landed as
https://crrev.com/960e25ea2ce3515f2ae5132c796a9b689f314168
Cr-Commit-Position: refs/heads/master@{#35310}