🏄 [heap] Add page evacuation mode for new->old

src/heap/mark-compact.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HEAP_MARK_COMPACT_H_
 #define V8_HEAP_MARK_COMPACT_H_
 
 #include "src/base/bits.h"
 #include "src/heap/spaces.h"
 #include "src/heap/store-buffer.h"
@@ skipping 480 matching lines @@
   MarkingParity marking_parity() { return marking_parity_; }
 
   // Concurrent and parallel sweeping support. If required_freed_bytes was set
   // to a value larger than 0, then sweeping returns after a block of at least
   // required_freed_bytes was freed. If required_freed_bytes was set to zero
   // then the whole given space is swept. It returns the size of the maximum
   // continuous freed memory chunk.
   int SweepInParallel(PagedSpace* space, int required_freed_bytes,
                       int max_pages = 0);
 
+  int SweepInParallel(std::vector<Page*>& pages, PagedSpace* space,
+                      int required_freed_bytes, int max_pages = 0);
+
   // Sweeps a given page concurrently to the sweeper threads. It returns the
   // size of the maximum continuous freed memory chunk.
   int SweepInParallel(Page* page, PagedSpace* space);
 
   // Ensures that sweeping is finished.
   //
   // Note: Can only be called safely from main thread.
   void EnsureSweepingCompleted();
 
   void SweepOrWaitUntilSweepingCompleted(Page* page);
@@ skipping 60 matching lines @@
         return &swept_code_space_pages_;
       case MAP_SPACE:
         return &swept_map_space_pages_;
       default:
         UNREACHABLE();
     }
     return nullptr;
   }
 
  private:
+  class EvacuateNewSpacePageVisitor;
   class EvacuateNewSpaceVisitor;
   class EvacuateOldSpaceVisitor;
   class EvacuateVisitorBase;
   class HeapObjectVisitor;
   class SweeperTask;
 
   typedef std::vector<Page*> SweepingList;
 
   explicit MarkCompactCollector(Heap* heap);
 
@@ skipping 229 matching lines @@
   List<NewSpacePage*> newspace_evacuation_candidates_;
 
   base::Mutex swept_pages_mutex_;
   List<Page*> swept_old_space_pages_;
   List<Page*> swept_code_space_pages_;
   List<Page*> swept_map_space_pages_;
 
   SweepingList sweeping_list_old_space_;
   SweepingList sweeping_list_code_space_;
   SweepingList sweeping_list_map_space_;
+  SweepingList* sweeping_list_shared_;

[Michael Lippautz, 2016/04/08 07:09:58]

Not too happy about cluttering up all the sweeper lists.

Maybe we should create  a SweeperState that contains all the lists and the
corresponding mutex and getters?

[Hannes Payer (out of office), 2016/04/08 10:42:40]

Yeah, that does not really scale. You can do that in a follow-up cl.

I don't like the name sweeping_list_shared_; The pages are promoted pages, let's
call it like that.

[Michael Lippautz, 2016/04/08 11:30:00]

It's sweeping_list_promoted_pages_ for now.

 
   // True if we are collecting slots to perform evacuation from evacuation
   // candidates.
   bool compacting_;
 
   // True if concurrent or parallel sweeping is currently in progress.
   bool sweeping_in_progress_;
 
   // Semaphore used to synchronize sweeper tasks.
   base::Semaphore pending_sweeper_tasks_semaphore_;
@@ skipping 20 matching lines @@
  private:
   MarkCompactCollector* collector_;
 };
 
 
 const char* AllocationSpaceName(AllocationSpace space);
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_HEAP_MARK_COMPACT_H_