Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: appengine/logdog/coordinator/endpoints/logs/list.go

Issue 1863973002: LogDog: Update to archival V2. (Closed) Base URL: https://github.com/luci/luci-go@grpcutil-errors
Patch Set: Fix proto comment. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/logdog/coordinator/endpoints/logs/list.go
diff --git a/appengine/logdog/coordinator/endpoints/logs/list.go b/appengine/logdog/coordinator/endpoints/logs/list.go
index 9b631dc39166303bed6c09fd8e55405c6f34d6ed..1157ce313f4479adbf89f62d58eb56c759d54727 100644
--- a/appengine/logdog/coordinator/endpoints/logs/list.go
+++ b/appengine/logdog/coordinator/endpoints/logs/list.go
@@ -7,7 +7,6 @@ package logs
import (
ds "github.com/luci/gae/service/datastore"
"github.com/luci/luci-go/appengine/logdog/coordinator"
- "github.com/luci/luci-go/appengine/logdog/coordinator/config"
"github.com/luci/luci-go/appengine/logdog/coordinator/hierarchy"
"github.com/luci/luci-go/common/api/logdog_coordinator/logs/v1"
"github.com/luci/luci-go/common/grpcutil"
@@ -25,6 +24,7 @@ const (
// List returns log stream paths rooted under the hierarchy.
func (s *Server) List(c context.Context, req *logdog.ListRequest) (*logdog.ListResponse, error) {
+ svc := s.GetServices()
hr := hierarchy.Request{
Base: req.Path,
Recursive: req.Recursive,
@@ -36,7 +36,7 @@ func (s *Server) List(c context.Context, req *logdog.ListRequest) (*logdog.ListR
// Non-admin users may not request purged results.
if req.IncludePurged {
- if err := config.IsAdminUser(c); err != nil {
+ if err := coordinator.IsAdminUser(c, svc); err != nil {
log.Fields{
log.ErrorKey: err,
}.Errorf(c, "Non-superuser requested to see purged paths. Denying.")
« no previous file with comments | « appengine/logdog/coordinator/endpoints/logs/get_test.go ('k') | appengine/logdog/coordinator/endpoints/logs/list_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698