Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2454)

Unified Diff: appengine/logdog/coordinator/endpoints/logs/get_test.go

Issue 1863973002: LogDog: Update to archival V2. (Closed) Base URL: https://github.com/luci/luci-go@grpcutil-errors
Patch Set: Minor fixes, works in dev now. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/logdog/coordinator/endpoints/logs/get_test.go
diff --git a/appengine/logdog/coordinator/endpoints/logs/get_test.go b/appengine/logdog/coordinator/endpoints/logs/get_test.go
index 657f568d945fdb0443dc14f69db3222b3f22e485..ed858f224f3d87d41b9d42a38f9af4339a67b444 100644
--- a/appengine/logdog/coordinator/endpoints/logs/get_test.go
+++ b/appengine/logdog/coordinator/endpoints/logs/get_test.go
@@ -162,7 +162,7 @@ func TestGet(t *testing.T) {
// Generate our test stream.
desc := ct.TestLogStreamDescriptor(c, "foo/bar")
ls := ct.TestLogStream(c, desc)
- if err := ls.Put(ds.Get(c)); err != nil {
+ if err := ds.Get(c).Put(ls); err != nil {
panic(err)
}
@@ -280,13 +280,17 @@ func TestGet(t *testing.T) {
panic(err)
}
+ now := tc.Now().UTC()
+
gsc.put("testbucket", "stream", lbuf.Bytes())
gsc.put("testbucket", "index", ibuf.Bytes())
ls.State = coordinator.LSArchived
+ ls.TerminatedTime = now
+ ls.ArchivedTime = now
ls.ArchiveStreamURL = "gs://testbucket/stream"
ls.ArchiveIndexURL = "gs://testbucket/index"
}
- if err := ls.Put(ds.Get(c)); err != nil {
+ if err := ds.Get(c).Put(ls); err != nil {
panic(err)
}
@@ -297,7 +301,7 @@ func TestGet(t *testing.T) {
Convey(`When the log stream is purged`, func() {
ls.Purged = true
- if err := ls.Put(ds.Get(c)); err != nil {
+ if err := ds.Get(c).Put(ls); err != nil {
panic(err)
}
@@ -422,7 +426,7 @@ func TestGet(t *testing.T) {
})
Convey(`Will return Internal if the protobuf descriptor data is corrupt.`, func() {
- // We can't use "ls.Put" here because it validates the protobuf!
+ ls.SetDSValidate(false)
ls.Descriptor = []byte{0x00} // Invalid protobuf, zero tag.
if err := ds.Get(c).Put(ls); err != nil {
panic(err)

Powered by Google App Engine
This is Rietveld 408576698