Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 1863963004: WebUI: add functional test for text_defaults.css (Closed)

Created:
4 years, 8 months ago by Dan Beam
Modified:
4 years, 8 months ago
Reviewers:
dschuyler, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: add functional test for text_defaults.css R=dschuyler@chromium.org,sky@chromium.org BUG=601051 NOTRY=true # see patchset 1 Committed: https://crrev.com/d632b7693d284d21a7e6314f932be23767c33386 Cr-Commit-Position: refs/heads/master@{#385882}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/web_ui_browser_test.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/test/data/webui/text_defaults_browsertest.js View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Dan Beam
+dschuyler@ for chrome/test/data/webui/ +sky@ for everything else
4 years, 8 months ago (2016-04-07 02:04:42 UTC) #1
sky
LGTM
4 years, 8 months ago (2016-04-07 19:12:22 UTC) #2
dschuyler
LGTM with nit https://codereview.chromium.org/1863963004/diff/1/chrome/test/data/webui/text_defaults_browsertest.js File chrome/test/data/webui/text_defaults_browsertest.js (right): https://codereview.chromium.org/1863963004/diff/1/chrome/test/data/webui/text_defaults_browsertest.js#newcode27 chrome/test/data/webui/text_defaults_browsertest.js:27: * @return {string} The HTML decoded ...
4 years, 8 months ago (2016-04-07 20:54:31 UTC) #3
Dan Beam
https://codereview.chromium.org/1863963004/diff/1/chrome/test/data/webui/text_defaults_browsertest.js File chrome/test/data/webui/text_defaults_browsertest.js (right): https://codereview.chromium.org/1863963004/diff/1/chrome/test/data/webui/text_defaults_browsertest.js#newcode27 chrome/test/data/webui/text_defaults_browsertest.js:27: * @return {string} The HTML decoded text of |maybeHtml|. ...
4 years, 8 months ago (2016-04-07 21:03:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863963004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863963004/20001
4 years, 8 months ago (2016-04-07 21:06:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 21:39:56 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 21:41:16 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d632b7693d284d21a7e6314f932be23767c33386
Cr-Commit-Position: refs/heads/master@{#385882}

Powered by Google App Engine
This is Rietveld 408576698