Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1863963003: Update SpeechRecognizer to indicate if it's done when reporting results. (Closed)

Created:
4 years, 8 months ago by anwilson
Modified:
4 years, 8 months ago
Reviewers:
thatguy, qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update SpeechRecognizer to indicate if it's done when reporting results. BUG= R=thatguy@google.com Committed: https://chromium.googlesource.com/external/mojo/+/df84061f960cbdf53d851d7382cadb2297db4ebd

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M mojo/dart/packages/mojo_services/lib/speech_recognizer/speech_recognizer.mojom.dart View 6 chunks +20 lines, -5 lines 0 comments Download
M mojo/services/speech_recognizer/interfaces/speech_recognizer.mojom View 1 chunk +3 lines, -2 lines 0 comments Download
M services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizerServiceImpl.java View 4 chunks +6 lines, -7 lines 2 comments Download

Messages

Total messages: 7 (3 generated)
anwilson
4 years, 8 months ago (2016-04-07 00:07:06 UTC) #3
thatguy
lgtm https://codereview.chromium.org/1863963003/diff/1/services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizerServiceImpl.java File services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizerServiceImpl.java (right): https://codereview.chromium.org/1863963003/diff/1/services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizerServiceImpl.java#newcode196 services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizerServiceImpl.java:196: candidates.toArray(new UtteranceCandidate[candidates.size()]), complete); formatting
4 years, 8 months ago (2016-04-07 05:17:27 UTC) #4
anwilson
https://codereview.chromium.org/1863963003/diff/1/services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizerServiceImpl.java File services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizerServiceImpl.java (right): https://codereview.chromium.org/1863963003/diff/1/services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizerServiceImpl.java#newcode196 services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizerServiceImpl.java:196: candidates.toArray(new UtteranceCandidate[candidates.size()]), complete); On 2016/04/07 05:17:27, thatguy wrote: > ...
4 years, 8 months ago (2016-04-07 17:02:22 UTC) #5
anwilson
4 years, 8 months ago (2016-04-07 17:02:54 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
df84061f960cbdf53d851d7382cadb2297db4ebd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698