Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: extensions/browser/api/web_contents_capture_client.cc

Issue 1863953002: <webview>: Fix missing transparency in captureVisibleRegion(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix build break Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/web_contents_capture_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/web_contents_capture_client.cc
diff --git a/extensions/browser/api/web_contents_capture_client.cc b/extensions/browser/api/web_contents_capture_client.cc
index 78c3760667ec99357e349436c3d47990c00f47dd..6dff09e7d56e467494624ef2205c7e80ab9c65a6 100644
--- a/extensions/browser/api/web_contents_capture_client.cc
+++ b/extensions/browser/api/web_contents_capture_client.cc
@@ -107,6 +107,7 @@ bool WebContentsCaptureClient::EncodeBitmap(const SkBitmap& bitmap,
DCHECK(base64_result);
std::vector<unsigned char> data;
SkAutoLockPixels screen_capture_lock(bitmap);
+ const bool should_discard_alpha = !ClientAllowsTransparency();
bool encoded = false;
std::string mime_type;
switch (image_format_) {
@@ -118,10 +119,8 @@ bool WebContentsCaptureClient::EncodeBitmap(const SkBitmap& bitmap,
mime_type = kMimeTypeJpeg;
break;
case api::extension_types::IMAGE_FORMAT_PNG:
- encoded =
- gfx::PNGCodec::EncodeBGRASkBitmap(bitmap,
- true, // Discard transparency.
- &data);
+ encoded = gfx::PNGCodec::EncodeBGRASkBitmap(bitmap, should_discard_alpha,
+ &data);
mime_type = kMimeTypePng;
break;
default:
« no previous file with comments | « extensions/browser/api/web_contents_capture_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698