extensions/browser/api/guest_view/web_view/web_view_internal_api.h - Issue 1863953002: <webview>: Fix missing transparency in captureVisibleRegion().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/guest_view/web_view/web_view_internal_api.h

Issue 1863953002: <webview>: Fix missing transparency in captureVisibleRegion(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix build break Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | extensions/browser/api/guest_view/web_view/web_view_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/guest_view/web_view/web_view_internal_api.h

diff --git a/extensions/browser/api/guest_view/web_view/web_view_internal_api.h b/extensions/browser/api/guest_view/web_view/web_view_internal_api.h

index 388491eac49ceed464d0007dadfc4d6eb1a0613c..9f646e697218f9b0bf21b937c6d70c47b898a411 100644

--- a/extensions/browser/api/guest_view/web_view/web_view_internal_api.h

+++ b/extensions/browser/api/guest_view/web_view/web_view_internal_api.h

@@ -43,7 +43,7 @@ class WebViewInternalCaptureVisibleRegionFunction

public:

DECLARE_EXTENSION_FUNCTION("webViewInternal.captureVisibleRegion",

WEBVIEWINTERNAL_CAPTUREVISIBLEREGION);

- WebViewInternalCaptureVisibleRegionFunction() {}

+ WebViewInternalCaptureVisibleRegionFunction();

protected:

~WebViewInternalCaptureVisibleRegionFunction() override {}

@@ -54,9 +54,12 @@ class WebViewInternalCaptureVisibleRegionFunction

// extensions::WebContentsCaptureClient:

bool IsScreenshotEnabled() override;

+ bool ClientAllowsTransparency() override;

void OnCaptureSuccess(const SkBitmap& bitmap) override;

void OnCaptureFailure(FailureReason reason) override;

+ bool is_guest_transparent_;

DISALLOW_COPY_AND_ASSIGN(WebViewInternalCaptureVisibleRegionFunction);

};