Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2910)

Unified Diff: extensions/browser/api/web_contents_capture_client.cc

Issue 1863953002: <webview>: Fix missing transparency in captureVisibleRegion(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply wjmaclean's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_contents_capture_client.cc
diff --git a/extensions/browser/api/web_contents_capture_client.cc b/extensions/browser/api/web_contents_capture_client.cc
index 78c3760667ec99357e349436c3d47990c00f47dd..6e2e5e221e00971998fee9871579d4c649c3e678 100644
--- a/extensions/browser/api/web_contents_capture_client.cc
+++ b/extensions/browser/api/web_contents_capture_client.cc
@@ -120,8 +120,9 @@ bool WebContentsCaptureClient::EncodeBitmap(const SkBitmap& bitmap,
case api::extension_types::IMAGE_FORMAT_PNG:
encoded =
gfx::PNGCodec::EncodeBGRASkBitmap(bitmap,
- true, // Discard transparency.
- &data);
+ /* Don't discard transparency if
+ * client allows transparency. */
Finnur 2016/04/07 10:08:33 Please avoid multi-line comments. This comment doe
avallee 2016/04/07 14:21:16 Replaced with a variable that documents what's goi
+ !ClientAllowsTransparency(), &data);
mime_type = kMimeTypePng;
break;
default:

Powered by Google App Engine
This is Rietveld 408576698