Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: extensions/browser/api/web_contents_capture_client.h

Issue 1863953002: <webview>: Fix missing transparency in captureVisibleRegion(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_API_WEB_CONTENTS_CAPTURE_CLIENT_H_ 5 #ifndef EXTENSIONS_BROWSER_API_WEB_CONTENTS_CAPTURE_CLIENT_H_
6 #define EXTENSIONS_BROWSER_API_WEB_CONTENTS_CAPTURE_CLIENT_H_ 6 #define EXTENSIONS_BROWSER_API_WEB_CONTENTS_CAPTURE_CLIENT_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "content/public/browser/readback_types.h" 9 #include "content/public/browser/readback_types.h"
10 #include "extensions/browser/extension_function.h" 10 #include "extensions/browser/extension_function.h"
(...skipping 10 matching lines...) Expand all
21 // Base class for capturing visible area of a WebContents. 21 // Base class for capturing visible area of a WebContents.
22 // This is used by both webview.captureVisibleRegion and tabs.captureVisibleTab. 22 // This is used by both webview.captureVisibleRegion and tabs.captureVisibleTab.
23 class WebContentsCaptureClient { 23 class WebContentsCaptureClient {
24 public: 24 public:
25 WebContentsCaptureClient() {} 25 WebContentsCaptureClient() {}
26 26
27 protected: 27 protected:
28 virtual ~WebContentsCaptureClient() {} 28 virtual ~WebContentsCaptureClient() {}
29 29
30 virtual bool IsScreenshotEnabled() = 0; 30 virtual bool IsScreenshotEnabled() = 0;
31 virtual bool ContentsHasTransparency() = 0;
wjmaclean 2016/04/06 12:39:21 This name is a bit misleading, since it may return
avallee 2016/04/06 14:12:27 Done.
31 32
32 enum FailureReason { 33 enum FailureReason {
33 FAILURE_REASON_UNKNOWN, 34 FAILURE_REASON_UNKNOWN,
34 FAILURE_REASON_ENCODING_FAILED, 35 FAILURE_REASON_ENCODING_FAILED,
35 FAILURE_REASON_VIEW_INVISIBLE 36 FAILURE_REASON_VIEW_INVISIBLE
36 }; 37 };
37 bool CaptureAsync(content::WebContents* web_contents, 38 bool CaptureAsync(content::WebContents* web_contents,
38 const api::extension_types::ImageDetails* image_detail, 39 const api::extension_types::ImageDetails* image_detail,
39 const content::ReadbackRequestCallback callback); 40 const content::ReadbackRequestCallback callback);
40 bool EncodeBitmap(const SkBitmap& bitmap, std::string* base64_result); 41 bool EncodeBitmap(const SkBitmap& bitmap, std::string* base64_result);
41 virtual void OnCaptureFailure(FailureReason reason) = 0; 42 virtual void OnCaptureFailure(FailureReason reason) = 0;
42 virtual void OnCaptureSuccess(const SkBitmap& bitmap) = 0; 43 virtual void OnCaptureSuccess(const SkBitmap& bitmap) = 0;
43 void CopyFromBackingStoreComplete(const SkBitmap& bitmap, 44 void CopyFromBackingStoreComplete(const SkBitmap& bitmap,
44 content::ReadbackResponse response); 45 content::ReadbackResponse response);
45 46
46 private: 47 private:
47 // The format (JPEG vs PNG) of the resulting image. Set in RunAsync(). 48 // The format (JPEG vs PNG) of the resulting image. Set in RunAsync().
48 api::extension_types::ImageFormat image_format_; 49 api::extension_types::ImageFormat image_format_;
49 50
50 // Quality setting to use when encoding jpegs. Set in RunAsync(). 51 // Quality setting to use when encoding jpegs. Set in RunAsync().
51 int image_quality_; 52 int image_quality_;
52 53
53 DISALLOW_COPY_AND_ASSIGN(WebContentsCaptureClient); 54 DISALLOW_COPY_AND_ASSIGN(WebContentsCaptureClient);
54 }; 55 };
55 56
56 } // namespace extensions 57 } // namespace extensions
57 58
58 #endif // EXTENSIONS_BROWSER_API_WEB_CONTENTS_CAPTURE_CLIENT_H_ 59 #endif // EXTENSIONS_BROWSER_API_WEB_CONTENTS_CAPTURE_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698