Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 186393002: Update QuickOffice ids. (Closed)

Created:
6 years, 9 months ago by benwells
Modified:
6 years, 9 months ago
Reviewers:
Sam McNally, mtomasz
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Update QuickOffice ids. Remove an old ID used by QO for development, and add an ID to the extension on the internal store instead. BUG=348871 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255297

Patch Set 1 #

Total comments: 5

Patch Set 2 : Remove retainEntries change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/mime_types_handler.cc View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
benwells
6 years, 9 months ago (2014-03-04 04:47:46 UTC) #1
Sam McNally
https://codereview.chromium.org/186393002/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/186393002/diff/1/chrome/common/extensions/api/_permission_features.json#newcode379 chrome/common/extensions/api/_permission_features.json:379: "whitelist": [ Does this need to live in another ...
6 years, 9 months ago (2014-03-04 04:55:00 UTC) #2
benwells
https://codereview.chromium.org/186393002/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/186393002/diff/1/chrome/common/extensions/api/_permission_features.json#newcode379 chrome/common/extensions/api/_permission_features.json:379: "whitelist": [ On 2014/03/04 04:55:00, Sam McNally wrote: > ...
6 years, 9 months ago (2014-03-04 05:50:18 UTC) #3
Sam McNally
lgtm
6 years, 9 months ago (2014-03-04 07:41:17 UTC) #4
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 9 months ago (2014-03-05 00:20:29 UTC) #5
benwells
The CQ bit was unchecked by benwells@chromium.org
6 years, 9 months ago (2014-03-05 00:20:32 UTC) #6
benwells
+mtomasz for file browser private change
6 years, 9 months ago (2014-03-05 00:28:38 UTC) #7
mtomasz
lgtm with a nit https://codereview.chromium.org/186393002/diff/1/chrome/common/extensions/mime_types_handler.cc File chrome/common/extensions/mime_types_handler.cc (right): https://codereview.chromium.org/186393002/diff/1/chrome/common/extensions/mime_types_handler.cc#newcode26 chrome/common/extensions/mime_types_handler.cc:26: extension_misc::kStreamsPrivateTestExtensionId}; nit: Is this indentation ...
6 years, 9 months ago (2014-03-06 00:28:29 UTC) #8
benwells
https://codereview.chromium.org/186393002/diff/1/chrome/common/extensions/mime_types_handler.cc File chrome/common/extensions/mime_types_handler.cc (right): https://codereview.chromium.org/186393002/diff/1/chrome/common/extensions/mime_types_handler.cc#newcode26 chrome/common/extensions/mime_types_handler.cc:26: extension_misc::kStreamsPrivateTestExtensionId}; On 2014/03/06 00:28:29, mtomasz wrote: > nit: Is ...
6 years, 9 months ago (2014-03-06 03:23:11 UTC) #9
mtomasz
LGTM https://codereview.chromium.org/186393002/diff/1/chrome/common/extensions/mime_types_handler.cc File chrome/common/extensions/mime_types_handler.cc (right): https://codereview.chromium.org/186393002/diff/1/chrome/common/extensions/mime_types_handler.cc#newcode26 chrome/common/extensions/mime_types_handler.cc:26: extension_misc::kStreamsPrivateTestExtensionId}; On 2014/03/06 03:23:11, benwells wrote: > On ...
6 years, 9 months ago (2014-03-06 03:26:12 UTC) #10
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 9 months ago (2014-03-06 03:46:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/186393002/20001
6 years, 9 months ago (2014-03-06 03:48:31 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 10:36:50 UTC) #13
Message was sent while issue was closed. 
Change committed as 255297

Powered by Google App Engine
This is Rietveld 408576698