Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1863923003: Fix null context GenBuffers (Closed)

Created:
4 years, 8 months ago by Chris Dalton
Modified:
4 years, 8 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix null context GenBuffers Fixes the null context to not return 0 for GenBuffers. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1863923003 Committed: https://skia.googlesource.com/skia/+/a957b8a114bb003d0975a5d5737c30b00e5940ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/gpu/gl/GrGLCreateNullInterface.cpp View 3 chunks +8 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Chris Dalton
This fixes the crash seen on the buffer change.
4 years, 8 months ago (2016-04-06 19:59:23 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863923003/1
4 years, 8 months ago (2016-04-06 19:59:35 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-06 19:59:37 UTC) #6
bsalomon
On 2016/04/06 19:59:37, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
4 years, 8 months ago (2016-04-06 20:33:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863923003/1
4 years, 8 months ago (2016-04-06 20:35:45 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 20:36:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a957b8a114bb003d0975a5d5737c30b00e5940ab

Powered by Google App Engine
This is Rietveld 408576698