Have gcl report when unit tests are (or might be) missing from a change....

Have gcl report when unit tests are (or might be) missing from a change.
It's a very rough guess now, and will probably need some refinement as we 
see what it misses and where its false positives are too annoying.

Protect against side effects from cwd changes.

BUG=6056
TEST=try creating or uploading a change with a new .cpp file and no unit-test
    changes

[Pam (message me for reviews), 2009-01-22 00:03:33]

New patch, this time over in src/release/, with better handling of the current
directory.

[Pam (message me for reviews), 2009-01-22 00:51:31]

New patch up.

Thanks,
- Pam

[jam, 2009-01-22 00:57:26]

lgtm

http://codereview.chromium.org/18639/diff/206/207
File src/release/gcl.py (right):

http://codereview.chromium.org/18639/diff/206/207#newcode202
Line 202: def _NonDeletedFileList(self):
I'm not that familiar with the python style guide, why is there an underscore
here?  If this is for member functions (or just ones with no side effect),
shouldn't FileList have it too?

[jam, 2009-01-22 00:57:49]

oh also before checking in run scons to update the other 6 files..

[Pam (message me for reviews), 2009-01-22 01:14:58]

New patch includes the other 5 files too.

http://codereview.chromium.org/18639/diff/206/207
File src/release/gcl.py (right):

http://codereview.chromium.org/18639/diff/206/207#newcode202
Line 202: def _NonDeletedFileList(self):
On 2009/01/22 00:57:26, John Abd-El-Malek wrote:
> I'm not that familiar with the python style guide, why is there an underscore
> here?  If this is for member functions (or just ones with no side effect),
> shouldn't FileList have it too?

It's for "private" member functions. FileList is called from outside the class.
Probably some of the other methods ought to be marked private too, but I felt
that was outside the scope of this change.