Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1863773002: Update documentation for BattOr device mapping. (Closed)

Created:
4 years, 8 months ago by alexandermont
Modified:
4 years, 8 months ago
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Update documentation for BattOr device mapping. Added additional documentation explaining how to use Battor-to-device mapping files. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/501ed91927682f0fd3160f0371d968424b5cbb62

Patch Set 1 #

Patch Set 2 : update docs #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
M devil/devil/utils/battor_device_mapping.py View 1 2 3 2 chunks +74 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
alexandermont
4 years, 8 months ago (2016-04-05 22:10:08 UTC) #2
alexandermont
4 years, 8 months ago (2016-04-08 20:29:25 UTC) #3
alexandermont
4 years, 8 months ago (2016-04-11 23:35:55 UTC) #5
alexandermont
+nednguyen
4 years, 8 months ago (2016-04-11 23:36:10 UTC) #6
charliea (OOO until 10-5)
lgtm
4 years, 8 months ago (2016-04-14 15:49:35 UTC) #9
nednguyen
Your documentation looks great to me. However, I wonder whether we should put this as ...
4 years, 8 months ago (2016-04-14 16:19:17 UTC) #10
rnephew (Reviews Here)
https://codereview.chromium.org/1863773002/diff/40001/devil/devil/utils/battor_device_mapping.py File devil/devil/utils/battor_device_mapping.py (right): https://codereview.chromium.org/1863773002/diff/40001/devil/devil/utils/battor_device_mapping.py#newcode15 devil/devil/utils/battor_device_mapping.py:15: # Phones are identified by the following string: On ...
4 years, 8 months ago (2016-04-14 16:20:50 UTC) #12
nednguyen
Err, looks like this file is not a runnable script. Though it's still good to ...
4 years, 8 months ago (2016-04-14 16:22:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863773002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863773002/60001
4 years, 8 months ago (2016-04-14 17:30:29 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/501ed91927682f0fd3160f0371d968424b5cbb62
4 years, 8 months ago (2016-04-14 17:55:14 UTC) #18
nednguyen
4 years, 8 months ago (2016-04-14 19:14:09 UTC) #19
Message was sent while issue was closed.
On 2016/04/14 17:55:14, commit-bot: I haz the power wrote:
> Committed patchset #4 (id:60001) as
>
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Sorry, I am in the owner of catapult/ but my stamp was not supposed to replace
the stamp of devil's OWNERs to land this change. This is my bad, can devil's 
owners still take a look?

Powered by Google App Engine
This is Rietveld 408576698