Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1863733004: Fixes crashes in inliner: do not inline if icdata was cleared. (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes crashes in inliner: do not inline if icdata was cleared. Add some asserts. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/3d23c82d94b1f1941a3f8e22e99eebefcf587270

Patch Set 1 #

Patch Set 2 : better #

Patch Set 3 : bb #

Patch Set 4 : bb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M runtime/vm/compiler.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 7 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/weak_code.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
srdjan
4 years, 8 months ago (2016-04-06 21:12:04 UTC) #2
rmacnak
lgtm
4 years, 8 months ago (2016-04-06 21:33:48 UTC) #4
srdjan
4 years, 8 months ago (2016-04-06 21:44:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
3d23c82d94b1f1941a3f8e22e99eebefcf587270 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698