|
|
Chromium Code Reviews|
Created:
4 years, 8 months ago by ghost stip (do not use) Modified:
4 years, 8 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove many tests to stop gunking up the waterfall.
Worried that all these failing tests are causing very long reboot cycles, harming capacity.
BUG=
Committed: https://crrev.com/ded30ffeb31c5702ffeb85b7bcd44d05c681261f
Cr-Commit-Position: refs/heads/master@{#385452}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Just use breakpad_unittests instead. #Patch Set 3 : Add content_browsertests. #Messages
Total messages: 30 (14 generated)
Description was changed from ========== Remove many tests to stop gunking up the waterfall. BUG= ========== to ========== Remove many tests to stop gunking up the waterfall. Worried that all these failing tests are causing very long reboot cycles, harming capacity. BUG= ==========
stip@chromium.org changed reviewers: + jbudorick@chromium.org, maruel@chromium.org
Description was changed from ========== Remove many tests to stop gunking up the waterfall. Worried that all these failing tests are causing very long reboot cycles, harming capacity. BUG= ========== to ========== Remove many tests to stop gunking up the waterfall. Worried that all these failing tests are causing very long reboot cycles, harming capacity. TBR=maruel@chromium.org BUG= ==========
The CQ bit was checked by stip@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863723002/1
https://codereview.chromium.org/1863723002/diff/1/testing/buildbot/gn_isolate... File testing/buildbot/gn_isolate_map.pyl (left): https://codereview.chromium.org/1863723002/diff/1/testing/buildbot/gn_isolate... testing/buildbot/gn_isolate_map.pyl:139: "breakpad_unittests": { ?
https://codereview.chromium.org/1863723002/diff/1/testing/buildbot/gn_isolate... File testing/buildbot/gn_isolate_map.pyl (left): https://codereview.chromium.org/1863723002/diff/1/testing/buildbot/gn_isolate... testing/buildbot/gn_isolate_map.pyl:139: "breakpad_unittests": { On 2016/04/05 19:57:01, jbudorick wrote: > ? manage.py complained. should I bail out and figure out what's what?
The CQ bit was unchecked by stip@chromium.org
stip@chromium.org changed reviewers: + dpranke@chromium.org
Dirk, I think we might need an actual review here :)
was the error something along the lines of "breakpad_unitests listed in gn_isolate_map.pyl but not in any .json files"? That looks like it is technically correct, because the other bots that run breakpad_unittests aren't using swarming and are listed in the SKIP block of manage.py. It's probably better to add breakpad_unittests to SKIP_GN_ISOLATE_MAP_TARGETS in manage.py than it is to delete it altogether.
that was the error and I just realized: let's test breakpad_unittests instead.
The CQ bit was checked by stip@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863723002/20001
The CQ bit was unchecked by jbudorick@chromium.org
On 2016/04/06 00:55:03, stip wrote: > that was the error and I just realized: let's test breakpad_unittests instead. can we at least have this run content_browsertests too, as that's what's on the main waterfall?
On 2016/04/06 01:00:23, jbudorick wrote: > On 2016/04/06 00:55:03, stip wrote: > > that was the error and I just realized: let's test breakpad_unittests instead. > > can we at least have this run content_browsertests too, as that's what's on the > main waterfall? sure, updated. ptal
Description was changed from ========== Remove many tests to stop gunking up the waterfall. Worried that all these failing tests are causing very long reboot cycles, harming capacity. TBR=maruel@chromium.org BUG= ========== to ========== Remove many tests to stop gunking up the waterfall. Worried that all these failing tests are causing very long reboot cycles, harming capacity. BUG= ==========
lgtm
The CQ bit was checked by stip@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863723002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863723002/40001
Message was sent while issue was closed.
Description was changed from ========== Remove many tests to stop gunking up the waterfall. Worried that all these failing tests are causing very long reboot cycles, harming capacity. BUG= ========== to ========== Remove many tests to stop gunking up the waterfall. Worried that all these failing tests are causing very long reboot cycles, harming capacity. BUG= ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove many tests to stop gunking up the waterfall. Worried that all these failing tests are causing very long reboot cycles, harming capacity. BUG= ========== to ========== Remove many tests to stop gunking up the waterfall. Worried that all these failing tests are causing very long reboot cycles, harming capacity. BUG= Committed: https://crrev.com/ded30ffeb31c5702ffeb85b7bcd44d05c681261f Cr-Commit-Position: refs/heads/master@{#385452} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ded30ffeb31c5702ffeb85b7bcd44d05c681261f Cr-Commit-Position: refs/heads/master@{#385452} |
