Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1863723002: Remove many tests to stop gunking up the waterfall. (Closed)

Created:
4 years, 8 months ago by ghost stip (do not use)
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove many tests to stop gunking up the waterfall. Worried that all these failing tests are causing very long reboot cycles, harming capacity. BUG= Committed: https://crrev.com/ded30ffeb31c5702ffeb85b7bcd44d05c681261f Cr-Commit-Position: refs/heads/master@{#385452}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Just use breakpad_unittests instead. #

Patch Set 3 : Add content_browsertests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -240 lines) Patch
M testing/buildbot/chromium.android.json View 1 2 2 chunks +0 lines, -240 lines 0 comments Download

Messages

Total messages: 30 (14 generated)
ghost stip (do not use)
4 years, 8 months ago (2016-04-05 19:35:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863723002/1
4 years, 8 months ago (2016-04-05 19:35:21 UTC) #6
jbudorick
https://codereview.chromium.org/1863723002/diff/1/testing/buildbot/gn_isolate_map.pyl File testing/buildbot/gn_isolate_map.pyl (left): https://codereview.chromium.org/1863723002/diff/1/testing/buildbot/gn_isolate_map.pyl#oldcode139 testing/buildbot/gn_isolate_map.pyl:139: "breakpad_unittests": { ?
4 years, 8 months ago (2016-04-05 19:57:01 UTC) #7
ghost stip (do not use)
https://codereview.chromium.org/1863723002/diff/1/testing/buildbot/gn_isolate_map.pyl File testing/buildbot/gn_isolate_map.pyl (left): https://codereview.chromium.org/1863723002/diff/1/testing/buildbot/gn_isolate_map.pyl#oldcode139 testing/buildbot/gn_isolate_map.pyl:139: "breakpad_unittests": { On 2016/04/05 19:57:01, jbudorick wrote: > ? ...
4 years, 8 months ago (2016-04-05 20:42:53 UTC) #8
ghost stip (do not use)
Dirk, I think we might need an actual review here :)
4 years, 8 months ago (2016-04-05 20:45:02 UTC) #11
Dirk Pranke
was the error something along the lines of "breakpad_unitests listed in gn_isolate_map.pyl but not in ...
4 years, 8 months ago (2016-04-05 20:56:20 UTC) #12
ghost stip (do not use)
that was the error and I just realized: let's test breakpad_unittests instead.
4 years, 8 months ago (2016-04-06 00:55:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863723002/20001
4 years, 8 months ago (2016-04-06 00:55:37 UTC) #15
jbudorick
On 2016/04/06 00:55:03, stip wrote: > that was the error and I just realized: let's ...
4 years, 8 months ago (2016-04-06 01:00:23 UTC) #17
ghost stip (do not use)
On 2016/04/06 01:00:23, jbudorick wrote: > On 2016/04/06 00:55:03, stip wrote: > > that was ...
4 years, 8 months ago (2016-04-06 01:08:43 UTC) #18
jbudorick
lgtm
4 years, 8 months ago (2016-04-06 01:12:31 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863723002/40001
4 years, 8 months ago (2016-04-06 01:14:00 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/127869) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, ...
4 years, 8 months ago (2016-04-06 07:14:57 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863723002/40001
4 years, 8 months ago (2016-04-06 13:07:07 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-06 13:56:33 UTC) #28
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 13:59:04 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ded30ffeb31c5702ffeb85b7bcd44d05c681261f
Cr-Commit-Position: refs/heads/master@{#385452}

Powered by Google App Engine
This is Rietveld 408576698