Add a std::nullptr_t constructor to base::WeakPtr.

Add a std::nullptr_t constructor to base::WeakPtr.

BUG=none

Committed: https://crrev.com/efeb19b8a79d8f953f0e432a7491a67ea113b9d8
Cr-Commit-Position: refs/heads/master@{#385267}

[dcheng, 2016-04-05 17:08:12]

dcheng@chromium.org changed reviewers:
+ danakj@chromium.org

[dcheng, 2016-04-05 17:08:13]

Motivated by https://codereview.chromium.org/1830883002/, where multiple people
wondered about this. Matches scoped_ptr^Wstd::unique_ptr but not scoped_refptr
(which is also missing a constructor from std::nullptr_t).

[sky, 2016-04-05 17:10:21]

sky@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-04-05 17:10:21]

Thanks!

https://codereview.chromium.org/1863643002/diff/1/base/memory/weak_ptr.h
File base/memory/weak_ptr.h (right):

https://codereview.chromium.org/1863643002/diff/1/base/memory/weak_ptr.h#newc...
base/memory/weak_ptr.h:206: WeakPtr(std::nullptr_t) : ptr_(nullptr) { }
nit: no {}. I would hope git cl format converts '{ }' -> '{}', but maybe not.

[dcheng, 2016-04-05 17:16:33]

https://codereview.chromium.org/1863643002/diff/1/base/memory/weak_ptr.h
File base/memory/weak_ptr.h (right):

https://codereview.chromium.org/1863643002/diff/1/base/memory/weak_ptr.h#newc...
base/memory/weak_ptr.h:206: WeakPtr(std::nullptr_t) : ptr_(nullptr) { }
On 2016/04/05 at 17:10:21, sky wrote:
> nit: no {}. I would hope git cl format converts '{ }' -> '{}', but maybe not.

I forgot to run git cl format =S

[sky, 2016-04-05 17:28:49]

LGTM

[danakj, 2016-04-05 17:50:05]

LGTM

[dcheng, 2016-04-05 18:28:38]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-04-05 18:29:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863643002/20001

[commit-bot: I haz the power, 2016-04-05 20:07:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-05 20:08:55]

Description was changed from

==========
Add a std::nullptr_t constructor to base::WeakPtr.

BUG=none
==========

to

==========
Add a std::nullptr_t constructor to base::WeakPtr.

BUG=none

Committed: https://crrev.com/efeb19b8a79d8f953f0e432a7491a67ea113b9d8
Cr-Commit-Position: refs/heads/master@{#385267}
==========

[commit-bot: I haz the power, 2016-04-05 20:08:56]

Patchset 2 (id:??) landed as
https://crrev.com/efeb19b8a79d8f953f0e432a7491a67ea113b9d8
Cr-Commit-Position: refs/heads/master@{#385267}