chrome/browser/resources/settings/privacy_page/privacy_page.html - Issue 1863623002: Convert Site Details to settings-subpage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 1863623002: Convert Site Details to settings-subpage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/privacy_page/privacy_page.html

diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html

index 0b66963cf71a20eb3ef2dc272383ccffec131be0..1b1c2b0f1873a634abef189ce9d674644a0015d6 100644

--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html

+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html

@@ -215,13 +215,12 @@

</settings-subpage>

</template>

-

- <neon-animatable id="site-details">

- <site-details

- site="{{selectedSite}}"

- current-route="{{currentRoute}}">

- </site-details>

- </neon-animatable>

+ <template is="dom-if" name="site-details">

+ <settings-subpage

+ page-title="[[i18n('siteSettingsSiteDetailsPageTitle')]]">

+ <site-details site="[[selectedSite]]"</site-details>

michaelpg 2016/04/06 02:20:35 missing >

+ </settings-subpage>

+ </template>

</settings-animated-pages>

</template>

« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/site_details.css » ('j') | no next file with comments »