Convert Site Details to settings-subpage.

chrome/browser/resources/settings/privacy_page/privacy_page.html

Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 0b66963cf71a20eb3ef2dc272383ccffec131be0..73c714185898448cbdf3a39acf29e5cfd125c1fa 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -215,13 +215,15 @@
         </settings-subpage>
       </template>
 
-      <!-- TODO(finnur): switch to settings-subpage (crbug.com/597314). -->
-      <neon-animatable id="site-details">
-        <site-details
-            site="{{selectedSite}}"
-            current-route="{{currentRoute}}">
-        </site-details>
-      </neon-animatable>
+      <template is="dom-if" name="site-details">
+        <settings-subpage
+            page-title="[[i18n('siteSettingsSiteDetailsPageTitle')]]">
+          <site-details
+              site="{{selectedSite}}"

[michaelpg, 2016/04/05 18:22:53]

nit: while you're here, since this isn't "notify: true", make it explicitly
1-way bound: site="[[selectedSite]]"

[Finnur, 2016/04/06 00:25:19]

Good idea.

+              current-route="{{currentRoute}}">

[michaelpg, 2016/04/05 18:22:53]

is currentRoute used by site-details?

[Finnur, 2016/04/06 00:25:19]

Hmm... Good catch.

+          </site-details>
+        </settings-subpage>
+      </template>
     </settings-animated-pages>
   </template>
   <script src="privacy_page.js"></script>