Convert Site Details to settings-subpage.

chrome/browser/resources/settings/site_settings/site_details_permission.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'site-details-permission' handles showing the state of one permission, such
  * as Geolocation, for a given origin.
  */
 Polymer({
@@ skipping 28 matching lines @@
     this.addWebUIListener('contentSettingSitePermissionChanged',
         this.sitePermissionChanged_.bind(this));
   },
 
   /**
    * Sets the site to display.
    * @param {!SiteException} site The site to display.
    * @private
    */
   siteChanged_: function(site) {
-    this.$.details.hidden = true;
+    // Finish this asynchronously to give |category| a chance to be set first.

[michaelpg, 2016/04/05 18:22:53]

May be preferable to keep this synchronous by making the observer dependent on
|category| being defined:

observers: ['siteChanged_(site, category)']

[Finnur, 2016/04/06 00:25:19]

Doh. Of course. Can't believe I overlooked that. Much better solution.

+    this.async(function() {
+      this.$.details.hidden = true;
 
-    var prefsProxy = settings.SiteSettingsPrefsBrowserProxyImpl.getInstance();
-    prefsProxy.getExceptionList(this.category).then(function(exceptionList) {
-      for (var i = 0; i < exceptionList.length; ++i) {
-        if (exceptionList[i].origin == site.origin) {
-          // TODO(finnur): Convert to use attrForSelected.
-          this.$.permission.selected = exceptionList[i].setting ==
-              settings.PermissionStringValues.ALLOW ? 0 : 1;
-          this.$.details.hidden = false;
+      var prefsProxy = settings.SiteSettingsPrefsBrowserProxyImpl.getInstance();
+      prefsProxy.getExceptionList(this.category).then(function(exceptionList) {
+        for (var i = 0; i < exceptionList.length; ++i) {
+          if (exceptionList[i].origin == site.origin) {
+            // TODO(finnur): Convert to use attrForSelected.
+            this.$.permission.selected = exceptionList[i].setting ==
+                settings.PermissionStringValues.ALLOW ? 0 : 1;
+            this.$.details.hidden = false;
+          }
         }
-      }
-    }.bind(this));
+      }.bind(this));
+    });
   },
 
   /**
    * Called when a site within a category has been changed.
    * @param {number} category The category that changed.
    * @param {string} site The site that changed.
    * @private
    */
   sitePermissionChanged_: function(category, site) {
     if (category == this.category && (site == '' || site == this.site.origin)) {
@@ skipping 23 matching lines @@
     // TODO(finnur): Compare with event.detail.item.dataset.permission directly
     //     once attrForSelected is in use.
     var action = event.detail.item.innerText;
     var value = (action == this.i18n_.allowAction) ?
         settings.PermissionValues.ALLOW :
         settings.PermissionValues.BLOCK;
     this.setCategoryPermissionForOrigin(
         this.site.origin, '', value, this.category);
   },
 });