Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 18636002: Remove multiple inheritance support from the bindings generator (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, do-not-use, lgombos
Visibility:
Public.

Description

Remove multiple inheritance support from the bindings generator Remove multiple inheritance support from the bindings generator as this is no longer supported in Web IDL and it makes the generator more complex than it needs to be. Multiple inheritance support is no longer needed now that our SVG interfaces have been updated to use Web IDL 'implements' statements instead. BUG=256968 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -68 lines) Patch
M Source/bindings/scripts/CodeGeneratorV8.pm View 8 chunks +12 lines, -59 lines 0 comments Download
M Source/bindings/scripts/IDLParser.pm View 4 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 5 months ago (2013-07-03 10:19:07 UTC) #1
haraken
Great! LGTM.
7 years, 5 months ago (2013-07-03 10:24:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18636002/1
7 years, 5 months ago (2013-07-03 10:46:07 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-03 12:12:06 UTC) #4
Message was sent while issue was closed.
Change committed as 153496

Powered by Google App Engine
This is Rietveld 408576698