Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: content/browser/resources/media/dump_creator.js

Issue 1863593002: Updated description of WebRTC event log functionality on the chrome://webrtc-internals page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/resources/media/dump_creator.js
diff --git a/content/browser/resources/media/dump_creator.js b/content/browser/resources/media/dump_creator.js
index 1f13256670e4de189bf40fe697ecccacb5be8a08..7c1e3379e98839425172722c73b411212369f358 100644
--- a/content/browser/resources/media/dump_creator.js
+++ b/content/browser/resources/media/dump_creator.js
@@ -62,14 +62,12 @@ var DumpCreator = (function() {
' and RTCP packets are logged. These do not include any audio or' +
' video information, nor any other types of personally identifiable' +
' information (so no IP addresses or URLs). Checking this box will' +
- ' enable the recording for ongoing WebRTC calls and for future' +
- ' WebRTC calls. When the box is unchecked or this page is closed,' +
- ' all ongoing recordings will be stopped and this recording' +
- ' functionality will be disabled for future WebRTC calls. Recording' +
- ' in multiple tabs or multiple recordings in the same tab is' +
- ' currently not supported. When enabling, a filename for the' +
- ' recording can be selected. If an existing file is selected, it' +
- ' will be overwritten. </p>';
+ ' enable the recording only for currently ongoing WebRTC calls. When' +
tommi (sloooow) - chröme 2016/04/07 12:59:40 nit: is 'only' needed?
Ivo-OOO until feb 6 2016/04/07 13:19:56 Not really, I will remove it.
+ ' the box is unchecked or this page is closed, all ongoing recordings' +
tommi (sloooow) - chröme 2016/04/07 12:59:40 nit: s/ongoing/active
Ivo-OOO until feb 6 2016/04/07 13:19:56 Done.
+ ' will be stopped. Recording in multiple tabs or multiple recordings' +
+ ' in the same tab is currently not supported. When enabling, a' +
+ ' filename for the recording can be selected. If an existing file is' +
+ ' selected, it will be overwritten. </p>';
content.getElementsByTagName('a')[0].addEventListener(
'click', this.onDownloadData_.bind(this));
content.getElementsByTagName('input')[0].addEventListener(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698