Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 | 5 |
| 6 /** | 6 /** |
| 7 * Provides the UI for dump creation. | 7 * Provides the UI for dump creation. |
| 8 */ | 8 */ |
| 9 var DumpCreator = (function() { | 9 var DumpCreator = (function() { |
| 10 /** | 10 /** |
| (...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 55 ' each time or move the produced files before enabling again.</p>' + | 55 ' each time or move the produced files before enabling again.</p>' + |
| 56 '<p><label><input type=checkbox>' + | 56 '<p><label><input type=checkbox>' + |
| 57 'Enable diagnostic packet and event recording</label></p>' + | 57 'Enable diagnostic packet and event recording</label></p>' + |
| 58 '<p class=audio-recordings-info>A diagnostic packet and event' + | 58 '<p class=audio-recordings-info>A diagnostic packet and event' + |
| 59 ' recording can be used for analyzing various issues related to' + | 59 ' recording can be used for analyzing various issues related to' + |
| 60 ' thread starvation, jitter buffers or bandwidth estimation. Two' + | 60 ' thread starvation, jitter buffers or bandwidth estimation. Two' + |
| 61 ' types of data are logged. First, incoming and outgoing RTP headers' + | 61 ' types of data are logged. First, incoming and outgoing RTP headers' + |
| 62 ' and RTCP packets are logged. These do not include any audio or' + | 62 ' and RTCP packets are logged. These do not include any audio or' + |
| 63 ' video information, nor any other types of personally identifiable' + | 63 ' video information, nor any other types of personally identifiable' + |
| 64 ' information (so no IP addresses or URLs). Checking this box will' + | 64 ' information (so no IP addresses or URLs). Checking this box will' + |
| 65 ' enable the recording for ongoing WebRTC calls and for future' + | 65 ' enable the recording only for currently ongoing WebRTC calls. When' + |
|
tommi (sloooow) - chröme
2016/04/07 12:59:40
nit: is 'only' needed?
Ivo-OOO until feb 6
2016/04/07 13:19:56
Not really, I will remove it.
| |
| 66 ' WebRTC calls. When the box is unchecked or this page is closed,' + | 66 ' the box is unchecked or this page is closed, all ongoing recordings' + |
|
tommi (sloooow) - chröme
2016/04/07 12:59:40
nit: s/ongoing/active
Ivo-OOO until feb 6
2016/04/07 13:19:56
Done.
| |
| 67 ' all ongoing recordings will be stopped and this recording' + | 67 ' will be stopped. Recording in multiple tabs or multiple recordings' + |
| 68 ' functionality will be disabled for future WebRTC calls. Recording' + | 68 ' in the same tab is currently not supported. When enabling, a' + |
| 69 ' in multiple tabs or multiple recordings in the same tab is' + | 69 ' filename for the recording can be selected. If an existing file is' + |
| 70 ' currently not supported. When enabling, a filename for the' + | 70 ' selected, it will be overwritten. </p>'; |
| 71 ' recording can be selected. If an existing file is selected, it' + | |
| 72 ' will be overwritten. </p>'; | |
| 73 content.getElementsByTagName('a')[0].addEventListener( | 71 content.getElementsByTagName('a')[0].addEventListener( |
| 74 'click', this.onDownloadData_.bind(this)); | 72 'click', this.onDownloadData_.bind(this)); |
| 75 content.getElementsByTagName('input')[0].addEventListener( | 73 content.getElementsByTagName('input')[0].addEventListener( |
| 76 'click', this.onAudioDebugRecordingsChanged_.bind(this)); | 74 'click', this.onAudioDebugRecordingsChanged_.bind(this)); |
| 77 content.getElementsByTagName('input')[1].addEventListener( | 75 content.getElementsByTagName('input')[1].addEventListener( |
| 78 'click', this.onEventLogRecordingsChanged_.bind(this)); | 76 'click', this.onEventLogRecordingsChanged_.bind(this)); |
| 79 } | 77 } |
| 80 | 78 |
| 81 DumpCreator.prototype = { | 79 DumpCreator.prototype = { |
| 82 // Mark the diagnostic audio recording checkbox checked. | 80 // Mark the diagnostic audio recording checkbox checked. |
| (...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 143 var enabled = this.root_.getElementsByTagName('input')[1].checked; | 141 var enabled = this.root_.getElementsByTagName('input')[1].checked; |
| 144 if (enabled) { | 142 if (enabled) { |
| 145 chrome.send('enableEventLogRecordings'); | 143 chrome.send('enableEventLogRecordings'); |
| 146 } else { | 144 } else { |
| 147 chrome.send('disableEventLogRecordings'); | 145 chrome.send('disableEventLogRecordings'); |
| 148 } | 146 } |
| 149 }, | 147 }, |
| 150 }; | 148 }; |
| 151 return DumpCreator; | 149 return DumpCreator; |
| 152 })(); | 150 })(); |
| OLD | NEW |