Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1863593002:
Updated description of WebRTC event log functionality on the chrome://webrtc-internals page. (Closed)
|
Created:
4 years, 8 months ago by Ivo-OOO until feb 6 Modified:
4 years, 8 months ago Reviewers:
tommi (sloooow) - chröme CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdated description of WebRTC event log functionality on the chrome://webrtc-internals page.
The description incorrectly claimed that an event log would be recorded for any future WebRTC calls. This doesn't match the current behavior, and therefore the description should be updated.
BUG=chromium:600661
NOTRY=true
Committed: https://crrev.com/283ce5457218fbd6d8634444374a7fd9c38935ef
Cr-Commit-Position: refs/heads/master@{#385760}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Improved text based on Tommi's feedback. #Messages
Total messages: 17 (9 generated)
Description was changed from ========== Updated description of WebRTC event log functionality on the chrome://webrtc-internals page. The description incorrectly claimed that an event log would be recorded for any future WebRTC calls. This doesn't match the current behavior, and therefore the description should be updated. BUG=chromium:600661 ========== to ========== Updated description of WebRTC event log functionality on the chrome://webrtc-internals page. The description incorrectly claimed that an event log would be recorded for any future WebRTC calls. This doesn't match the current behavior, and therefore the description should be updated. BUG=chromium:600661 ==========
ivoc@chromium.org changed reviewers: + tommi@chromium.org
Hi Tommi, could you have a look at this small CL to update the description of the WebRTC event log functionality on the webrtc-internals page? Currently the claims made there don't match the actual behavior, so it would be nice to make the description more accurate. If possible I would like to get this in before the cut. Thanks!
lgtm https://codereview.chromium.org/1863593002/diff/1/content/browser/resources/m... File content/browser/resources/media/dump_creator.js (right): https://codereview.chromium.org/1863593002/diff/1/content/browser/resources/m... content/browser/resources/media/dump_creator.js:65: ' enable the recording only for currently ongoing WebRTC calls. When' + nit: is 'only' needed? https://codereview.chromium.org/1863593002/diff/1/content/browser/resources/m... content/browser/resources/media/dump_creator.js:66: ' the box is unchecked or this page is closed, all ongoing recordings' + nit: s/ongoing/active
The CQ bit was checked by ivoc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org Link to the patchset: https://codereview.chromium.org/1863593002/#ps20001 (title: "Improved text based on Tommi's feedback.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863593002/20001
https://codereview.chromium.org/1863593002/diff/1/content/browser/resources/m... File content/browser/resources/media/dump_creator.js (right): https://codereview.chromium.org/1863593002/diff/1/content/browser/resources/m... content/browser/resources/media/dump_creator.js:65: ' enable the recording only for currently ongoing WebRTC calls. When' + On 2016/04/07 12:59:40, tommi-sloooow wrote: > nit: is 'only' needed? Not really, I will remove it. https://codereview.chromium.org/1863593002/diff/1/content/browser/resources/m... content/browser/resources/media/dump_creator.js:66: ' the box is unchecked or this page is closed, all ongoing recordings' + On 2016/04/07 12:59:40, tommi-sloooow wrote: > nit: s/ongoing/active Done.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Updated description of WebRTC event log functionality on the chrome://webrtc-internals page. The description incorrectly claimed that an event log would be recorded for any future WebRTC calls. This doesn't match the current behavior, and therefore the description should be updated. BUG=chromium:600661 ========== to ========== Updated description of WebRTC event log functionality on the chrome://webrtc-internals page. The description incorrectly claimed that an event log would be recorded for any future WebRTC calls. This doesn't match the current behavior, and therefore the description should be updated. BUG=chromium:600661 NOTRY=true ==========
The CQ bit was checked by ivoc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863593002/20001
Message was sent while issue was closed.
Description was changed from ========== Updated description of WebRTC event log functionality on the chrome://webrtc-internals page. The description incorrectly claimed that an event log would be recorded for any future WebRTC calls. This doesn't match the current behavior, and therefore the description should be updated. BUG=chromium:600661 NOTRY=true ========== to ========== Updated description of WebRTC event log functionality on the chrome://webrtc-internals page. The description incorrectly claimed that an event log would be recorded for any future WebRTC calls. This doesn't match the current behavior, and therefore the description should be updated. BUG=chromium:600661 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Updated description of WebRTC event log functionality on the chrome://webrtc-internals page. The description incorrectly claimed that an event log would be recorded for any future WebRTC calls. This doesn't match the current behavior, and therefore the description should be updated. BUG=chromium:600661 NOTRY=true ========== to ========== Updated description of WebRTC event log functionality on the chrome://webrtc-internals page. The description incorrectly claimed that an event log would be recorded for any future WebRTC calls. This doesn't match the current behavior, and therefore the description should be updated. BUG=chromium:600661 NOTRY=true Committed: https://crrev.com/283ce5457218fbd6d8634444374a7fd9c38935ef Cr-Commit-Position: refs/heads/master@{#385760} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/283ce5457218fbd6d8634444374a7fd9c38935ef Cr-Commit-Position: refs/heads/master@{#385760} |
