Prepare Chrome Extensions for ES2015 RegExp semantics

extensions/renderer/safe_builtins.cc

Index: extensions/renderer/safe_builtins.cc
diff --git a/extensions/renderer/safe_builtins.cc b/extensions/renderer/safe_builtins.cc
index fbd88bdb15f3ee1278455b446159ecfcbc0386f7..9999680c1909de404e325adc07af73bb11b8d160 100644
--- a/extensions/renderer/safe_builtins.cc
+++ b/extensions/renderer/safe_builtins.cc
@@ -80,7 +80,7 @@ const char kScript[] =
     "            ['indexOf', 'slice', 'split', 'substr', 'toUpperCase',\n"
     "             'replace']);\n"
     "saveBuiltin(RegExp,\n"
-    "            ['test']);\n"

[Devlin, 2016/04/05 19:15:50]

You need to update the places that used $RegExp.test.

[Dan Ehrenberg, 2016/04/05 20:20:57]

That had already been done in this patch; there was just one usage that I saw.

+    "            ['exec']);\n"

[Devlin, 2016/04/05 19:16:39]

Also, might be worth adding a comment here explaining why we use exec instead of
test (which is normally preferred).

[Dan Ehrenberg, 2016/04/05 20:20:57]

Added comments in both usage cases (exec is a valid thing to call directly, so
not sure why there'd be a comment here).

     "saveBuiltin(Error,\n"
     "            [],\n"
     "            ['captureStackTrace']);\n"