Chromium Code Reviews| Index: components/password_manager/core/browser/password_form_manager.cc |
| diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc |
| index 247d539498daa6df089b315eec3ee742a2dfb698..cd2f4ef5cd8ba96fca7c53a75ca0b93c24ad650c 100644 |
| --- a/components/password_manager/core/browser/password_form_manager.cc |
| +++ b/components/password_manager/core/browser/password_form_manager.cc |
| @@ -291,6 +291,7 @@ void PasswordFormManager::ProvisionallySave( |
| } |
| provisionally_saved_form_ = std::move(mutable_provisionally_saved_form); |
| other_possible_username_action_ = action; |
| + does_look_like_signup_form = credentials.does_look_like_signup_form; |
|
vabr (Chromium)
2016/04/06 01:31:57
Why do we have an extra copy of this when it is in
dvadym
2016/04/06 16:02:20
|provisionally_saved_form_| is reset in the end of
vabr (Chromium)
2016/04/06 22:42:11
Ah, fair enough. An alternative would be to copy i
|
| if (HasCompletedMatching()) |
| CreatePendingCredentials(); |
| @@ -619,7 +620,10 @@ void PasswordFormManager::SaveAsNewLogin() { |
| } else if (pending_credentials_.times_used == 0) { |
| if (!observed_form_.IsPossibleChangePasswordFormWithoutUsername()) |
| UploadPasswordForm(pending_credentials_.form_data, base::string16(), |
| - autofill::PASSWORD, std::string()); |
| + does_look_like_signup_form |
| + ? autofill::PROBABLY_ACCOUNT_CREATION_PASSWORD |
| + : autofill::PASSWORD, |
| + std::string()); |
| } else { |
| if (!observed_form_.IsPossibleChangePasswordFormWithoutUsername()) |
| SendAutofillVotes(observed_form_, &pending_credentials_); |